-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table filter interactions #119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side - thanks for incorporating all the comments 👍 🚀
Would be great if you could add the additional table example and remove any reference to the AG grid in the requirements and code. Other than that, all good from my side 👍
There are few more things I'm currently working on (and are the part of the PR Description - ToDos section):
In the meantime other parts of the PR are ready for review. FYI: @maxschulz-COL, @huong-li-nguyen 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Have a couple more suggestions, but I think we are getting there 💪
Need to be careful so that tests don't become unreadable! :)
vizro-core/tests/unit/vizro/actions/_callback_mapping/test_get_action_callback_mapping.py
Outdated
Show resolved
Hide resolved
vizro-core/tests/unit/vizro/actions/_callback_mapping/test_get_action_callback_mapping.py
Outdated
Show resolved
Hide resolved
vizro-core/tests/unit/vizro/actions/_callback_mapping/test_get_action_callback_mapping.py
Show resolved
Hide resolved
You beat me to my comment :) Reviewed the test, but happy to take another look once the above is done! |
…ble_filter_interaction
vizro-core/changelog.d/20231026_084022_petar_pejovic_table_filter_interaction.md
Outdated
Show resolved
Hide resolved
vizro-core/tests/unit/vizro/actions/_callback_mapping/test_get_action_callback_mapping.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, but please still adress the last open issues
…ble_filter_interaction
…ble_filter_interaction
Description
vm.Table
model when itsfigure
argument represents thedash.Datatable
object.Potential issues/inconsistencies:
vm.Table as output (of filter, parameter, on_page_load, filter_interactions) works fine because we always modify (as the action's result) outer Div component which ID we know. There are some problems when vm.Table is the input (trigger or state) of the action:
actions
on the vm.Table object actually means defining a callback where the trigger is underlying table component fully created by user. It means that we can't set underlying table ID and we need to "force" dashboard users to add the ID if the table is action's trigger.dash.Datatable
orAgGrid
. e.g. different filter_interaction input properties are considered and different way of calculating filter_interaction's result.TODOs:
Checklist
Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
(if applicable)Types of changes
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":