-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable turning off marks when step is define in slider components #115
Enable turning off marks when step is define in slider components #115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the bug! 🚀
...hangelog.d/20231016_131411_nadija_ratkusic_graca_components_range_slider_mark_step_bugfix.md
Outdated
Show resolved
Hide resolved
vizro-core/tests/unit/vizro/models/_components/form/test_range_slider.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!! 🚀
Could you answer one of the users who asked that this is now natively supported after merging? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nadijagraca I just saw that you've changed the default of the step size to 1 - what I meant was to keep the default untouched and just to configure step=1 and marks=None in the app.py if possible?
I don't think we should change the default to 1 - e.g. what happens if min and max are 0 and 1? The defaults should be similar to the underlying component.
Description
Alterations of slider and range_slider code.
{}
instead ofNone
Users can now set step, but turn off visible marks on their sliders by providing
marks=None
Screenshot
Checklist
Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
(if applicable)Types of changes
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":