-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update user guides and implement branch name prefix enforcement #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huong-li-nguyen
changed the title
Update user guides and implement branch prefix enforcement
Update user guides and implement branch name prefix enforcement
Oct 12, 2023
huong-li-nguyen
requested review from
Joseph-Perkins,
antonymilne and
maxschulz-COL
as code owners
October 12, 2023 20:25
huong-li-nguyen
requested review from
Anna-Xiong,
lingyielia,
l0uden,
petar-qb and
nadijagraca
October 12, 2023 20:26
l0uden
approved these changes
Oct 13, 2023
nadijagraca
approved these changes
Oct 13, 2023
maxschulz-COL
requested changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some small suggestions
maxschulz-COL
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: Current regex pattern ensures that the branch name starts with one of the specified prefixes, followed by a slash, and then allows for any combination of characters, numbers, slashes, dots, etc. after -> I've double checked that our automatic release branch names pass
Screenshot
Checklist
Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
(if applicable)Types of changes
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":