Skip to content

Commit

Permalink
Add todo for filter.build()
Browse files Browse the repository at this point in the history
  • Loading branch information
petar-qb committed Nov 26, 2024
1 parent 3c60502 commit ca6b4ad
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions vizro-core/src/vizro/models/_controls/filter.py
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,9 @@ def pre_build(self):
@_log_call
def build(self):
selector_build_obj = self.selector.build()
# TODO: Align the (dynamic) object's return structure with the figure's components when the Dash bug is fixed.
# This means returning an empty "html.Div(id=self.id, className="...")" as a placeholder from Filter.build().
# Also, make selector.title visible when the filter is reloading.
return dcc.Loading(id=self.id, children=selector_build_obj) if self._dynamic else selector_build_obj

def _validate_targeted_data(
Expand Down

0 comments on commit ca6b4ad

Please sign in to comment.