Skip to content

Commit

Permalink
Drop 3.13 for Vizro-AI
Browse files Browse the repository at this point in the history
  • Loading branch information
antonymilne committed Oct 16, 2024
1 parent 22dca55 commit b99aebe
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 19 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/test-integration-vizro-ai.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ jobs:
hatch-env: all.py3.11
- python-version: "3.12"
hatch-env: all.py3.12
- python-version: "3.13"
hatch-env: all.py3.13
- python-version: "3.12"
hatch-env: lower-bounds
label: lower bounds
Expand All @@ -63,8 +61,6 @@ jobs:
hatch-env: all.py3.11
- python-version: "3.12"
hatch-env: all.py3.12
- python-version: "3.13"
hatch-env: all.py3.13
- python-version: "3.12"
hatch-env: lower-bounds
label: lower bounds
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/test-unit-vizro-ai.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ jobs:
hatch-env: all.py3.11
- python-version: "3.12"
hatch-env: all.py3.12
- python-version: "3.13"
hatch-env: all.py3.13
- python-version: "3.12"
hatch-env: lower-bounds
label: lower bounds
Expand Down
29 changes: 18 additions & 11 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ ignore = [
"D401", # first-line should be in imperative mood
# D407 needs to be ignored as it otherwise messes up the formatting in our API docs
"D407", # missing dashed underline after section
"PD901" # allow using the generic variable name `df` for DataFrames
"PD901", # allow using the generic variable name `df` for DataFrames
]
select = [
"E", # pycodestyle errors
Expand All @@ -69,12 +69,25 @@ select = [
"C4", # flake8-comprehensions
"RUF", # Ruff-specific rules
"PL", # pylint
"PD", # pandas-vet
"UP", # pyupgrade
"PERF", # perflint
"FURB" # refurb
"PD", # pandas-vet
"UP", # pyupgrade
"PERF", # perflint
"FURB", # refurb
]


# TODO:
# trailing comma
# correct docstrings - tried to do this already but check
# format code in docs
# think about pydantic to python

[tool.ruff.lint.pyupgrade]
# Don't do PEP 604 rewrites (e.g. Union[str, int] -> str | int), even in files that import
# `from __future__ import annotations`. This is needed since pydantic relies on the runtime behavior in Python 3.9.
# When we drop Python 3.9 we can remove this setting.
keep-runtime-typing = true

[tool.ruff.lint.per-file-ignores]
# Tests can use magic values, assertions, and relative imports, ignore missing docstrings,
# compare to empty string
Expand All @@ -87,9 +100,3 @@ convention = "google"

[tool.ruff.lint.pylint]
max-args = 6

[tool.ruff.lint.pyupgrade]
# Don't do PEP 604 rewrites (e.g. Union[str, int] -> str | int), even in files that import
# `from __future__ import annotations`. This is needed since pydantic relies on the runtime behavior in Python 3.9.
# When we drop Python 3.9 we can remove this setting.
keep-runtime-typing = true
2 changes: 1 addition & 1 deletion vizro-ai/hatch.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[envs.all]

[[envs.all.matrix]]
python = ["3.9", "3.10", "3.11", "3.12", "3.13"]
python = ["3.9", "3.10", "3.11", "3.12"]

[envs.changelog]
dependencies = ["scriv"]
Expand Down
1 change: 0 additions & 1 deletion vizro-ai/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ classifiers = [
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13"
]
dependencies = [
"pandas",
Expand Down

0 comments on commit b99aebe

Please sign in to comment.