Skip to content

Commit

Permalink
Fix overflow of table
Browse files Browse the repository at this point in the history
  • Loading branch information
huong-li-nguyen committed Oct 31, 2023
1 parent 2e9ac08 commit 94dfd70
Show file tree
Hide file tree
Showing 5 changed files with 55 additions and 4 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
<!--
A new scriv changelog fragment.
Uncomment the section that is right (remove the HTML comment wrapper).
-->

<!--
### Highlights ✨
- A bullet item for the Highlights ✨ category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
<!--
### Removed
- A bullet item for the Removed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
<!--
### Added
- A bullet item for the Added category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
<!--
### Changed
- A bullet item for the Changed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
<!--
### Deprecated
- A bullet item for the Deprecated category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
-->

### Fixed

- Fix overflowing of `Table` ([#137](https://github.com/mckinsey/vizro/pull/137))

<!--
### Security
- A bullet item for the Security category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
-->
2 changes: 1 addition & 1 deletion vizro-core/src/vizro/models/_components/graph.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,5 +84,5 @@ def build(self):
className="chart_container",
),
color="grey",
parent_className="chart_container",
parent_className="loading-container",
)
4 changes: 3 additions & 1 deletion vizro-core/src/vizro/models/_components/table.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,5 +61,7 @@ def build(self):
],
className="table-container",
id=f"{self.id}_outer",
)
),
color="grey",
parent_className="loading-container",
)
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def expected_graph():
className="chart_container",
),
color="grey",
parent_className="chart_container",
parent_className="loading-container",
)


Expand Down
4 changes: 3 additions & 1 deletion vizro-core/tests/unit/vizro/models/_components/test_table.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ def expected_table():
],
className="table-container",
id="text_table_outer",
)
),
color="grey",
parent_className="loading-container",
)


Expand Down

0 comments on commit 94dfd70

Please sign in to comment.