Skip to content

Commit

Permalink
Update pydantic requirement and lint
Browse files Browse the repository at this point in the history
  • Loading branch information
huong-li-nguyen committed Oct 2, 2023
1 parent a7c0578 commit 8559f1d
Show file tree
Hide file tree
Showing 4 changed files with 43 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ repos:
- id: mypy
files: ^vizro-core/src/
additional_dependencies:
- pydantic<2.0.0
- pydantic>=1.10.13, <2

- repo: https://github.com/gitleaks/gitleaks
rev: v8.16.4
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
<!--
A new scriv changelog fragment.
Uncomment the section that is right (remove the HTML comment wrapper).
-->

<!--
### Removed
- A bullet item for the Removed category.
-->
<!--
### Added
- A bullet item for the Added category.
-->
<!--
### Changed
- A bullet item for the Changed category.
-->
<!--
### Deprecated
- A bullet item for the Deprecated category.
-->
<!--
### Fixed
- A bullet item for the Fixed category.
-->

### Security

- Update pydantic requirement to `pydantic>=1.10.13, <2` due to medium Snyk vulnerability ([#83](https://github.com/mckinsey/vizro/pull/83))
2 changes: 1 addition & 1 deletion vizro-core/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ dependencies = [
# 2.11 needed for https://dash.plotly.com/dash-in-jupyter
"dash_bootstrap_components",
"pandas",
"pydantic<2.0.0", # must be synced with pre-commit mypy hook
"pydantic>=1.10.13, <2", # must be synced with pre-commit mypy hook
"dash_daq",
"ipython>=8.10.0", # not directly required, pinned by Snyk to avoid a vulnerability: https://app.snyk.io/vuln/SNYK-PYTHON-IPYTHON-3318382
"numpy>=1.22.2", # not directly required, pinned by Snyk to avoid a vulnerability: https://security.snyk.io/vuln/SNYK-PYTHON-NUMPY-2321970
Expand Down
2 changes: 1 addition & 1 deletion vizro-core/snyk/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
dash>=2.11
dash_bootstrap_components
pandas
pydantic<2.4.0
pydantic>=1.10.13, <2
dash_daq
ipython>=8.10.0
numpy>=1.22.2
Expand Down

0 comments on commit 8559f1d

Please sign in to comment.