Remove factory function for line

mckinsey · Jul 17, 2024 · 5a0e5f4 · 5a0e5f4
1 parent a720697
commit 5a0e5f4
Show file tree

Hide file tree

Showing 4 changed files with 52 additions and 78 deletions.
diff --git a/vizro-core/examples/_chart-gallery/app.py b/vizro-core/examples/_chart-gallery/app.py
@@ -17,7 +17,6 @@
     sankey_page,
     scatter,
     time_column,
-    time_line,
     treemap,
     violin,
 )
@@ -69,7 +68,6 @@
         violin,
         ordered_bar,
         ordered_column,
-        time_line,
         time_column,
         treemap,
         magnitude_treemap,
@@ -109,7 +107,7 @@
                 ),
                 vm.NavLink(
                     label="Time",
-                    pages={"Time": ["Time-Line", "Time-Column"]},
+                    pages={"Time": ["Line", "Time-Column"]},
                     icon="Timeline",
                 ),
                 vm.NavLink(

diff --git a/vizro-core/examples/_chart-gallery/assets/images/charts/time-line.svg b/vizro-core/examples/_chart-gallery/assets/images/charts/time-line.svg
diff --git a/vizro-core/examples/_chart-gallery/utils/chart_factory.py b/vizro-core/examples/_chart-gallery/utils/chart_factory.py
@@ -11,61 +11,6 @@
 from .custom_extensions import CodeClipboard, butterfly
 
 
-def line_factory(id: str, title: str):
-    """Reusable function to create the page content for the line chart with a unique ID."""
-    return vm.Page(
-        id=id,
-        title=title,
-        layout=vm.Layout(grid=PAGE_GRID),
-        components=[
-            vm.Card(
-                text="""
-
-            #### What is a line chart?
-
-            A line chart presents a series of data points over a continuous interval or time period, joined together
-            with straight lines.
-
-            &nbsp;
-
-            #### When to use it?
-
-            You should select a line chart when you want to show trends over time. Usually, your y-axis will show a
-            quantitative value and your x-axis will be marked as a timescale or a sequence of intervals. You can also
-            display negative values below the x-axis. If you wish to group several lines (different data series) in the
-            same chart, try to limit yourself to 3-4 to avoid cluttering up your chart.
-        """
-            ),
-            vm.Graph(figure=px.line(DATA_DICT["stocks"], x="date", y="GOOG")),
-            CodeClipboard(
-                text="""
-                ```python
-                import vizro.models as vm
-                import vizro.plotly.express as px
-                from vizro import Vizro
-
-                stocks = px.data.stocks()
-
-                page = vm.Page(
-                    title="Line",
-                    components=[
-                        vm.Graph(
-                            figure=px.line(
-                                stocks, x="date", y="GOOG"
-                            )
-                        )
-                    ],
-                )
-
-                dashboard = vm.Dashboard(pages=[page])
-                Vizro().build(dashboard).run()
-                ```
-                """
-            ),
-        ],
-    )
-
-
 def scatter_factory(id: str, title: str):
     """Reusable function to create the page content for the scatter chart with a unique ID."""
     return vm.Page(

diff --git a/vizro-core/examples/_chart-gallery/utils/chart_pages.py b/vizro-core/examples/_chart-gallery/utils/chart_pages.py
@@ -8,7 +8,6 @@
     bar_factory,
     butterfly_factory,
     column_factory,
-    line_factory,
     scatter_factory,
     treemap_factory,
 )
@@ -21,8 +20,6 @@
 
 
 # PAGES -------------------------------------------------------------
-line = line_factory("Line", "Line")
-time_line = line_factory("Time-Line", "Line")
 time_column = column_factory("Time-Column", "Column")
 scatter = scatter_factory("Scatter", "Scatter")
 bar = bar_factory("Bar", "Bar")
@@ -35,6 +32,57 @@
 distribution_butterfly = butterfly_factory("Distribution-Butterfly", "Butterfly")
 
 
+line = vm.Page(
+    title="Line",
+    layout=vm.Layout(grid=PAGE_GRID),
+    components=[
+        vm.Card(
+            text="""
+
+            #### What is a line chart?
+
+            A line chart presents a series of data points over a continuous interval or time period, joined together
+            with straight lines.
+
+            &nbsp;
+
+            #### When to use it?
+
+            You should select a line chart when you want to show trends over time. Usually, your y-axis will show a
+            quantitative value and your x-axis will be marked as a timescale or a sequence of intervals. You can also
+            display negative values below the x-axis. If you wish to group several lines (different data series) in the
+            same chart, try to limit yourself to 3-4 to avoid cluttering up your chart.
+        """
+        ),
+        vm.Graph(figure=px.line(DATA_DICT["stocks"], x="date", y="GOOG")),
+        CodeClipboard(
+            text="""
+                ```python
+                import vizro.models as vm
+                import vizro.plotly.express as px
+                from vizro import Vizro
+
+                stocks = px.data.stocks()
+
+                page = vm.Page(
+                    title="Line",
+                    components=[
+                        vm.Graph(
+                            figure=px.line(
+                                stocks, x="date", y="GOOG"
+                            )
+                        )
+                    ],
+                )
+
+                dashboard = vm.Dashboard(pages=[page])
+                Vizro().build(dashboard).run()
+                ```
+                """
+        ),
+    ],
+)
+
 pie = vm.Page(
     title="Pie",
     layout=vm.Layout(grid=PAGE_GRID),