Merge branch 'main' into demo/add-sparkline-chart

mckinsey · Nov 14, 2024 · 3324576 · 3324576
2 parents 5048e2b + 36699ee
commit 3324576
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/vizro-core/examples/visual-vocabulary/custom_charts.py b/vizro-core/examples/visual-vocabulary/custom_charts.py
@@ -290,12 +290,18 @@ def diverging_stacked_bar(data_frame: pd.DataFrame, **kwargs) -> go.Figure:
     orientation = fig.data[0].orientation
     x_or_y = "x" if orientation == "h" else "y"
 
-    for trace_idx in range(len(fig.data) // 2):
+    for trace_idx in range(len(fig.data) // 2, len(fig.data)):
         fig.update_traces({f"{x_or_y}axis": f"{x_or_y}2"}, selector=trace_idx)
 
+    # Add ticksuffix and range limitations on both sids for correct interpretation of diverging stacked bar
+    # with percentage data
+    fig.update_layout({f"{x_or_y}axis": {"ticksuffix": "%"}})
     fig.update_layout({f"{x_or_y}axis2": fig.layout[f"{x_or_y}axis"]})
     fig.update_layout(
-        {f"{x_or_y}axis": {"autorange": "reversed", "domain": [0, 0.5]}, f"{x_or_y}axis2": {"domain": [0.5, 1]}}
+        {
+            f"{x_or_y}axis": {"domain": [0, 0.5], "range": [100, 0]},
+            f"{x_or_y}axis2": {"domain": [0.5, 1], "range": [0, 100]},
+        }
     )
 
     if orientation == "h":

diff --git a/vizro-core/examples/visual-vocabulary/pages/examples/diverging_stacked_bar.py b/vizro-core/examples/visual-vocabulary/pages/examples/diverging_stacked_bar.py
@@ -24,12 +24,16 @@ def diverging_stacked_bar(data_frame: pd.DataFrame, **kwargs) -> go.Figure:
     orientation = fig.data[0].orientation
     x_or_y = "x" if orientation == "h" else "y"
 
-    for trace_idx in range(len(fig.data) // 2):
+    for trace_idx in range(len(fig.data) // 2, len(fig.data)):
         fig.update_traces({f"{x_or_y}axis": f"{x_or_y}2"}, selector=trace_idx)
 
+    fig.update_layout({f"{x_or_y}axis": {"ticksuffix": "%"}})
     fig.update_layout({f"{x_or_y}axis2": fig.layout[f"{x_or_y}axis"]})
     fig.update_layout(
-        {f"{x_or_y}axis": {"autorange": "reversed", "domain": [0, 0.5]}, f"{x_or_y}axis2": {"domain": [0.5, 1]}}
+        {
+            f"{x_or_y}axis": {"domain": [0, 0.5], "range": [100, 0]},
+            f"{x_or_y}axis2": {"domain": [0.5, 1], "range": [0, 100]},
+        }
     )
 
     if orientation == "h":
@@ -63,6 +67,6 @@ def diverging_stacked_bar(data_frame: pd.DataFrame, **kwargs) -> go.Figure:
     data_frame=pastries,
     x=["Strongly Disagree", "Disagree", "Agree", "Strongly Agree"],
     y="pastry",
-    labels={"value": "Response count", "variable": "Opinion"},
+    labels={"value": "", "variable": "", "pastry": ""},
     title="I would recommend this pastry to my friends",
 )