Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit linkage include in tests to fix the ci test. #54

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

TheVeryDarkness
Copy link
Contributor

I guess brotli has already been a static library so we don't need that.

Tested on both macOS and Windows. I'm wondering why this line was added.

I guess brotlicommon-static has already been a static library so we don't need that.

Test this later on Windows.
@pkgw
Copy link
Collaborator

pkgw commented Oct 20, 2023

The point of the line is to try to make sure that library dependencies are listed in the correct order when they're passed to the linker. If you're linking with static libraries, the order in which they're specified matters — if I'm linking an executable that depends on liba.a and libb.a, and liba.a depends on libb.a, the link will fail if I mention them as libb.a liba.a on the command line. vcpkg-rs used to not always do that correctly.

Anyway, it seems that this is no longer an issue here, so let's drop it!

@pkgw pkgw merged commit fca97d6 into mcgoo:master Oct 20, 2023
9 checks passed
@TheVeryDarkness
Copy link
Contributor Author

TheVeryDarkness commented Oct 23, 2023

Thanks for your answering :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants