-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular air shower development with 2D MCEq #48
Draft
kotania
wants to merge
20
commits into
mceq-project:next_1_3_X
Choose a base branch
from
kotania:2DShow
base: next_1_3_X
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… vs polarized/unpolarized)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features added:
Some comments:
2D MCEq functionality can be enabled using the
config.enable_2D
flagThe proposed 2D MCEq matrices are defined on the 10 MeV-10 TeV grid and are nominally valid down to the energies of ~50 MeV (found through trial and error). All of the matrices are extended to low energies (<80 GeV) with the UrQMD 3.4 hadronic interaction model; can consider adding DPMJET as another low-energy model option.
Some of the code related to extracting decay matrices with muon helicity dependence enabled has been written based off of the old(er) version of
1_3_X
, which is why extraction of helicity-dependent matrices in2DShow
is not exactly in agreement with the newest1_3_X
(see https://github.com/kotania/MCEq/blob/2DShow/MCEq/data.py#L488 vs https://github.com/kotania/MCEq/blob/461ff75bab3ed70dd34559005976f6fe429fa2bc/MCEq/data.py#L421).The length of the Hankel frequency grid is available from
mceq_db["common"].attrs["k_dim"]
, however not all of the functions have access tomceq_db
, so extraction of the frequency grid length is kept aslen(config.k_grid)
for now.