Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempted fixes for cache creation on linux. #162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Attempted fixes for cache creation on linux. #162

wants to merge 1 commit into from

Conversation

VioletDarkKitty
Copy link

Fixes for https://github.com/mcedit/mcedit/issues/492 does not fix all
errors.

@Khroki
Copy link
Contributor

Khroki commented Jun 19, 2014

Just a note, you generally can't use tabs in mcedit's code or the file won't pass or even sometimes work. Replace tabs with spaces and it should pass. I've had a lot of errors in my test environment relating to accidentally doing that.

@Lechros
Copy link
Contributor

Lechros commented Jun 21, 2014

I use text editor's indent with 2 spaces each and does that work?

@Khroki
Copy link
Contributor

Khroki commented Jun 21, 2014

Yep, that works fine, as long as it's not a tab character. Can use as many spaces as you like.

@Lechros
Copy link
Contributor

Lechros commented Jun 21, 2014

Khroki was right!
Also, Khroki, can you change renderer.py so that pocket edition has same grass color as pc /and/ PC has dark oak tree and acasia tree leaves color?
Also is it possible to update levelDB with MCPE's new map? I don't think codewarrior will update anything before mcedit 2.0 and that means... no Pocket Edition until then

@Khroki
Copy link
Contributor

Khroki commented Jun 21, 2014

I've been wanting to tackle renderer.py for a bit now, it needs some pretty hefty changes to get up to date, it's also the cause of stuff like netherbrick fences and buttons not rendering correctly. It's just a bit more complicated to change as I need to add a bunch of renderers so I'll see what I can do.

As for pocket edition, I'll look into what's involved, but really no promises as to whether or not I can actually do anything. Not owning pocket edition doesn't help here.

Edit: looked into it, pocket edition's format hasn't been released to the public yet, but will be later, nothing I can do at this point in time. It has been given to codewarrior by mojang, but since he's not updating MCedit 1, yeah. Doubt I have the skill to implement it anyway.

@Lechros
Copy link
Contributor

Lechros commented Jun 21, 2014

Wish he release mcedit 2 fast or pls pls pls update mcedit 1.
And I wish mcedit 2 is java not stupid python. PocketMine can already import PC maps to PE now!

@Khroki
Copy link
Contributor

Khroki commented Jun 21, 2014

Well, I don't know how to program java lol, anyway, you know where I can get a small pocket save to test stuff on?

Edit: started on editing renderer.py, already got trees and carpet fixed.

@Lechros
Copy link
Contributor

Lechros commented Jun 22, 2014

Just search mcpe map on google and you can get older version maps.
Almost nobody share 0.9.0 maps yet. I can't use my phone for a while..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants