Skip to content
This repository has been archived by the owner on Jan 28, 2020. It is now read-only.

Delete localConfig.js #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

coreyappleby
Copy link

This file gets loaded after config.js and has all the default values, which makes it impossible to override node['statsd']['graphite_host'].

I ran into this on Ubuntu 14.04, but if it's happening elsewhere you might want to put the deletion in the default recipe.

This file gets loaded after config.js and has all the default values, which makes it impossible to override node['statsd']['graphite_host'].

I ran into this on Ubuntu 14.04, but if it's happening elsewhere you might want to put the deletion in the default recipe.
Copy link
Owner

@mburns mburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small request, otherwise looks good.

# We do our config in /etc/statsd/config.js, this isn't needed.
file '/etc/statsd/localConfig.js' do
action :delete
notifies :restart, "service[statsd]"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint nitpick: single quotes.

@scalp42
Copy link

scalp42 commented May 24, 2019

@coreyappleby any chance you can update the PR so we can get it merged by @mburns?

Thanks in advance!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants