Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open parents in addToSelection #766

Merged
merged 4 commits into from
Nov 25, 2023
Merged

Conversation

mbraak
Copy link
Owner

@mbraak mbraak commented Nov 23, 2023

addToSelection: open parent nodes if necessary; so it works the same as selectNode.

Copy link

github-actions bot commented Nov 23, 2023

Size Change: +5 B (0%)

Total Size: 27.9 kB

Filename Size Change
./lib/tree.jquery.js 6.19 kB +5 B (0%)
ℹ️ View Unchanged
Filename Size
./lib/dataLoader.js 853 B
./lib/dragAndDropHandler/dragElement.js 361 B
./lib/dragAndDropHandler/hitAreasGenerator.js 1.04 kB
./lib/dragAndDropHandler/index.js 2.23 kB
./lib/dragAndDropHandler/types.js 33 B
./lib/dragAndDropHandler/visibleNodeIterator.js 608 B
./lib/elementsRenderer.js 1.82 kB
./lib/jqtreeMethodTypes.js 33 B
./lib/jqtreeOptions.js 33 B
./lib/keyHandler.js 738 B
./lib/mouse.widget.js 1.17 kB
./lib/mouseWidgetTypes.js 33 B
./lib/node.js 3.42 kB
./lib/nodeElement/borderDropHint.js 386 B
./lib/nodeElement/folderElement.js 915 B
./lib/nodeElement/ghostDropHint.js 527 B
./lib/nodeElement/index.js 738 B
./lib/nodeUtils.js 194 B
./lib/saveStateHandler.js 1.55 kB
./lib/scrollHandler.js 492 B
./lib/scrollHandler/containerScrollParent.js 874 B
./lib/scrollHandler/createScrollParent.js 546 B
./lib/scrollHandler/documentScrollParent.js 1.04 kB
./lib/scrollHandler/types.js 33 B
./lib/selectNodeHandler.js 684 B
./lib/simple.widget.js 947 B
./lib/util.js 282 B
./lib/version.js 147 B

compressed-size-action

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a32d936) 91.03% compared to head (0ec13aa) 91.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #766   +/-   ##
=======================================
  Coverage   91.03%   91.04%           
=======================================
  Files          28       28           
  Lines        2310     2311    +1     
  Branches      616      616           
=======================================
+ Hits         2103     2104    +1     
  Misses        207      207           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbraak mbraak merged commit 5fad7f4 into dev Nov 25, 2023
6 checks passed
@mbraak mbraak deleted the open-parents-in-add-to-selection branch November 25, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant