Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace jqtree widget parameter #759

Merged
merged 17 commits into from
Nov 14, 2023
Merged

Replace jqtree widget parameter #759

merged 17 commits into from
Nov 14, 2023

Conversation

mbraak
Copy link
Owner

@mbraak mbraak commented Nov 6, 2023

Refactoring: make the parameters to the different handlers more specific.

Copy link

github-actions bot commented Nov 6, 2023

Size Change: +1.13 kB (+4%)

Total Size: 27.9 kB

Filename Size Change
./lib/dataLoader.js 853 B +35 B (+4%)
./lib/dragAndDropHandler/index.js 2.23 kB +141 B (+7%) 🔍
./lib/elementsRenderer.js 1.82 kB +90 B (+5%) 🔍
./lib/keyHandler.js 738 B +40 B (+6%) 🔍
./lib/nodeElement/folderElement.js 915 B +80 B (+10%) ⚠️
./lib/nodeElement/index.js 738 B +28 B (+4%)
./lib/saveStateHandler.js 1.55 kB +70 B (+5%) 🔍
./lib/scrollHandler.js 492 B +19 B (+4%)
./lib/selectNodeHandler.js 684 B -68 B (-9%)
./lib/tree.jquery.js 6.18 kB +626 B (+11%) ⚠️
./lib/types.js 0 B -33 B (removed) 🏆
./lib/dragAndDropHandler/types.js 33 B +33 B (new file) 🆕
./lib/jqtreeMethodTypes.js 33 B +33 B (new file) 🆕
./lib/mouseWidgetTypes.js 33 B +33 B (new file) 🆕
ℹ️ View Unchanged
Filename Size
./lib/dragAndDropHandler/dragElement.js 361 B
./lib/dragAndDropHandler/hitAreasGenerator.js 1.04 kB
./lib/dragAndDropHandler/visibleNodeIterator.js 608 B
./lib/jqtreeOptions.js 33 B
./lib/mouse.widget.js 1.17 kB
./lib/node.js 3.42 kB
./lib/nodeElement/borderDropHint.js 386 B
./lib/nodeElement/ghostDropHint.js 527 B
./lib/nodeUtils.js 194 B
./lib/scrollHandler/containerScrollParent.js 874 B
./lib/scrollHandler/createScrollParent.js 546 B
./lib/scrollHandler/documentScrollParent.js 1.04 kB
./lib/scrollHandler/types.js 33 B
./lib/simple.widget.js 947 B
./lib/util.js 282 B
./lib/version.js 147 B

compressed-size-action

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (1477d30) 90.57% compared to head (762655f) 91.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #759      +/-   ##
==========================================
+ Coverage   90.57%   91.03%   +0.46%     
==========================================
  Files          28       28              
  Lines        2227     2310      +83     
  Branches      619      616       -3     
==========================================
+ Hits         2017     2103      +86     
+ Misses        210      207       -3     
Files Coverage Δ
src/dragAndDropHandler/hitAreasGenerator.ts 97.05% <ø> (ø)
src/elementsRenderer.ts 96.20% <100.00%> (+0.12%) ⬆️
src/keyHandler.ts 98.24% <100.00%> (+0.06%) ⬆️
src/mouse.widget.ts 65.74% <ø> (ø)
src/nodeElement/borderDropHint.ts 0.00% <ø> (ø)
src/nodeElement/folderElement.ts 91.22% <100.00%> (+0.84%) ⬆️
src/nodeElement/ghostDropHint.ts 69.44% <ø> (ø)
src/scrollHandler.ts 92.00% <100.00%> (+0.33%) ⬆️
src/selectNodeHandler.ts 93.54% <75.00%> (-0.57%) ⬇️
src/tree.jquery.ts 94.01% <98.50%> (+0.67%) ⬆️
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbraak mbraak merged commit ee1a97f into dev Nov 14, 2023
6 checks passed
@mbraak mbraak deleted the replace-jqtree-widget-parameter branch November 14, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant