Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak upload method dependencies to be specified at a higher level, add LinkServer version check #404

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

multiplemonomials
Copy link
Collaborator

Summary of changes

As part of mcuboot support, we need a way to generate upload targets for things that aren't actual CMake build targets. We can alllllmost do that with the existing code, but not quite! Needed to move the add_dependencies() call to the upper level function.

I also noticed a bug while working on this: if old versions of LinkServer are given a hex file, they just treat it as a bin file and flash the ASCII text of the hex file into memory!!!! It's extremely confusing when it happens, and I added a check to catch this situation.

Impact of changes

Migration actions required

Documentation

None

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

Used this branch to successfully upload a bootloader and application to a target! Also verified on my machine that the LinkServer check works.

@lefebvresam lefebvresam merged commit 15ab0c3 into master Dec 18, 2024
52 checks passed
@lefebvresam lefebvresam deleted the dev/tweak-upload-method-deps branch December 18, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants