Tweak upload method dependencies to be specified at a higher level, add LinkServer version check #404
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
As part of mcuboot support, we need a way to generate upload targets for things that aren't actual CMake build targets. We can alllllmost do that with the existing code, but not quite! Needed to move the add_dependencies() call to the upper level function.
I also noticed a bug while working on this: if old versions of LinkServer are given a hex file, they just treat it as a bin file and flash the ASCII text of the hex file into memory!!!! It's extremely confusing when it happens, and I added a check to catch this situation.
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Used this branch to successfully upload a bootloader and application to a target! Also verified on my machine that the LinkServer check works.