Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactivate EMAC Greentea test #378

Merged
merged 6 commits into from
Oct 30, 2024
Merged

Conversation

multiplemonomials
Copy link
Collaborator

@multiplemonomials multiplemonomials commented Oct 27, 2024

Summary of changes

This PR reactivates the emac test (under connectivity/netsocket/tests/TESTS/network/emac). This test is a bit complex because it works by communicating with a second board running a CTP sever application. To avoid build system cancer, I had to move this application into its own repository. I also moved the common code used by both the CTP server and the Mbed test into its own CMake library, so they can share like 98% of their codebase.

Happily, once I did all this, the test worked fine on both devices I tested.

Impact of changes

  • EMAC test works again, so we have a way to verify that ethernet works

Migration actions required

Documentation

Updated https://github.com/mbed-ce/mbed-os/wiki/Running-the-Mbed-Greentea-Tests-Locally


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

I verified that the EMAC test passes on both LPC1768 and NUCLEO_F429ZI, using a K64F board as the CTP tester.


@multiplemonomials multiplemonomials merged commit e72b38a into master Oct 30, 2024
52 checks passed
@multiplemonomials multiplemonomials deleted the dev/reactivate-emac-test branch October 30, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants