Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M2354: Fix some TF-M minor issues #376

Merged
merged 2 commits into from
Oct 24, 2024
Merged

M2354: Fix some TF-M minor issues #376

merged 2 commits into from
Oct 24, 2024

Conversation

ccli8
Copy link

@ccli8 ccli8 commented Oct 21, 2024

Summary of changes

This fixes some minor issues of Nuvoton's M2354 target, including:

  1. TF-M import document
  2. Pre-create of cmake target mbed-m2354-tfm for use in custom_targets.

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

ccli8 added 2 commits October 18, 2024 16:24
@ccli8
M2354: Update TF-M import document
24aa822 
For Nuvoton M2354, this updates document to be consistent with
TF-M import.
@ccli8
M2354: Pre-create cmake target mbed-m2354-tfm for custom_targets
ae7a226 
For M2354 custom target, there is dilemma on cmake target mbed-m2354-tfm:
1. mbed-m2354-tfm is created in mbed-os M2354 cmake listfile, but may be used
   in custom_targets M2354 cmake listfile in advance.
2. Build system requires add_subdirectory(custom_targets) be placed in front of
   add_subdirectory(mbed-os).

To overcome above, mbed-m2354-tfm is pre-created on request and as singleton,
E.g.:
if(NOT TARGET mbed-m2354-tfm)
    add_library(mbed-m2354-tfm INTERFACE)
endif()
@multiplemonomials
Copy link
Collaborator

fwiw, at some point you may wish to migrate that readme file to the Mbed CE wiki. Might make it easier to edit. But not a today problem.

@multiplemonomials multiplemonomials merged commit af80d11 into mbed-ce:master Oct 24, 2024
52 checks passed
@ccli8 ccli8 deleted the nvt_m2354_fix_tfm_minor branch October 25, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@multiplemonomials multiplemonomials multiplemonomials approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccli8 @multiplemonomials