Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactivate some tests and functionality that had accidentally been disabled due to incorrect checks #372

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

multiplemonomials
Copy link
Collaborator

@multiplemonomials multiplemonomials commented Oct 10, 2024

Summary of changes

  • Some tests (crash-reporting and the mbed stats tests) would never be enabled, due to both incorrect TEST_SKIP issues and the fact that needed mbed_app.json options for these tests are disabled by default in Mbed. I added a new JSON file used for greentea that sets those options, and fixed the TEST_SKIP conditions
  • Due to the earlier COMPONENT_FLASHIAP removal, the PlatformStorage API (which, to be honest, I had never seen before, but apparently is used as an intermediary between the storage layer and upper layers of Mbed) was erroneously thinking that the flash IAP block device wasn't enabled and wasn't using it when it should have.
  • Crash reporting was not working on STM32H7 because it appears that the crash data was not getting written back to main memory before a reset. I fixed this by adding a cache clean operation.

Impact of changes

Migration actions required

Documentation

Updated the page that says how to run greentea tests locally.


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

Verified locally that the newly added tests pass on STM32H7!


@multiplemonomials multiplemonomials changed the title [draft] Reactivate some tests that were accidentally being skipped due to buildscript errors [draft] Reactivate some tests and functionality that was accidentally being disabled due to incorrect checks Oct 10, 2024
@multiplemonomials multiplemonomials changed the title [draft] Reactivate some tests and functionality that was accidentally being disabled due to incorrect checks [draft] Reactivate some tests and functionality that had accidentally been disabled due to incorrect checks Oct 10, 2024
@multiplemonomials multiplemonomials changed the title [draft] Reactivate some tests and functionality that had accidentally been disabled due to incorrect checks Reactivate some tests and functionality that had accidentally been disabled due to incorrect checks Oct 13, 2024
@multiplemonomials multiplemonomials merged commit b2d11fc into master Oct 14, 2024
52 checks passed
@multiplemonomials multiplemonomials deleted the dev/fix-a-few-skipped-tests branch October 14, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants