Upload: NUVOTON: Fix GDB restart command for pyOCD #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives chance to adjust GDB commands MBED_UPLOAD_LAUNCH_COMMANDS or MBED_UPLOAD_RESTART_COMMANDS for debug launch by implementing mbed_adjust_upload_debug_commands cmake function.
PyOCD debug restart is failed without this somehow. It appears the device under debug must be halted after MBED_UPLOAD_RESTART_COMMANDS, but this is broken. Change to "monitor reset halt" to fix it.
| function(mbed_upload_nuvoton_adjust_restart_command_for_pyocd target) | ||
| if(DEFINED MBED_UPLOAD_RESTART_COMMANDS AND | ||
| "${UPLOAD_METHOD}" STREQUAL "PYOCD") | ||
| set(MBED_UPLOAD_RESTART_COMMANDS "monitor reset halt" CACHE INTERNAL "" FORCE) |
There was a problem hiding this comment.
This is a good catch, but any reason not to adjust line 62 of UploadMethodPYOCD.cmake to just have monitor reset halt? That way it's fixed for all targets.
There was a problem hiding this comment.
I tested it locally with STM32H5 and it seems to work (though to be honest I have never really used the restart functionality and I'm not entirely sure how it's supposed to be different from reset)
There was a problem hiding this comment.
Not sure the restart command failure will happen on other targets. Anyway, I create another PR #350 to apply the change to all targets.
|
Closing since #350 is merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR includes two parts:
MBED_UPLOAD_LAUNCH_COMMANDSorMBED_UPLOAD_RESTART_COMMANDSfor debug launch by implementingmbed_adjust_upload_debug_commandscmake function.Pull request type