Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload: Support Nuvoton targets #334

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

ccli8
Copy link

@ccli8 ccli8 commented Aug 29, 2024

Summary of changes

This supports upload method for Nuvoton targets, including:

  • NUMAKER_PFM_NANO130
  • NUMAKER_PFM_NUC472
  • NUMAKER_PFM_M453
  • NUMAKER_PFM_M487
  • NUMAKER_IOT_M487
  • NUMAKER_IOT_M467
  • NUMAKER_IOT_M252
  • NUMAKER_IOT_M263A
  • NU_M2354

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

@multiplemonomials
Copy link
Collaborator

Thanks, this looks really clean!

Really only have one comment which is, I would love to have a way to detect whether the OpenOCD that CMake has found is the Nuvoton version and not the standard version. Otherwise it would be all too easy to accidentally have the wrong one on your PATH. Is there a specific version number that your OpenOCD builds report?

@ccli8
Copy link
Author

ccli8 commented Aug 30, 2024

Nuvoton customized openocd will fix version number to 0.10.022. Hopefully it can be used to tell from standard:

$ openocd --version
Open On-Chip Debugger 0.10.022.0-dev-00493-gd6db465b-dirty (2023-12-14-15:04)
Licensed under GNU GPL v2
For bug reports, read
        http://openocd.org/doc/doxygen/bugs.html

@multiplemonomials
Copy link
Collaborator

Hmm, next step would be updating FindOpenOCD.cmake to check the version number. I should be able to do that sometime within the next week.

@multiplemonomials
Copy link
Collaborator

multiplemonomials commented Sep 8, 2024

Okay once #340 is merged, you should be able to add code like

set(OPENOCD_VERSION_RANGE 0.10.022...0.10.22)

in each of the upload method config files

@multiplemonomials
Copy link
Collaborator

Also @ccli8 I have invited you to be a member of the mbed-ce organization on github! Thanks for all your contributions! This should give you access to non-protected branches on the main repository, let you edit the wiki, and let you review PRs.

@ccli8
Copy link
Author

ccli8 commented Sep 9, 2024

have invited you to be a member of the mbed-ce organization on github! Thanks for all your contributions! This should give you access to non-protected branches on the main repository, let you edit the wiki, and let you review PRs.

@multiplemonomials Thanks, we can make mbed-ce prominent and lasting.

Support targets include:
- NUMAKER_PFM_NANO130
- NUMAKER_PFM_NUC472
- NUMAKER_PFM_M453
- NUMAKER_PFM_M487
- NUMAKER_IOT_M487
- NUMAKER_IOT_M467
- NUMAKER_IOT_M252
- NUMAKER_IOT_M263A
- NU_M2354
This adds document to enable openocd upload method for Nuvoton
NuMicro Cortex-M series.
@ccli8 ccli8 force-pushed the nvt_upload_method branch from 942e8e2 to 06fe30a Compare September 9, 2024 05:24
@ccli8
Copy link
Author

ccli8 commented Sep 9, 2024

Following #340, added openocd version requirement (for Nuvoton fork version) into each config files:

set(OPENOCD_VERSION_RANGE 0.10.022...0.10.22)

@multiplemonomials multiplemonomials merged commit b352953 into mbed-ce:master Sep 9, 2024
10 checks passed
@ccli8 ccli8 deleted the nvt_upload_method branch September 9, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants