Update the custom target example #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build tests failed because of upload methods are not on the machine. I do not know what is supposed to do with this... |
|
Oh, just pass -DUPLOAD_METHOD=NONE to cmake in the CI script |
|
Ok, I did something but not sure I did it right :) |
It is not necessary to apologize, that is why we do it like this. I am also aware my english skill is no so high so every correction are welcomed. Please be so kind and review the changes i made. |
|
Just two more little fixes then good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will update the custom target example in few ways for be more easy to understand for novices, I hope.
The main reason is in context of mbed-ce/mbed-os#250