Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly generate service account name #964

Merged
merged 2 commits into from
Nov 3, 2024
Merged

properly generate service account name #964

merged 2 commits into from
Nov 3, 2024

Conversation

mazay
Copy link
Owner

@mazay mazay commented Nov 3, 2024

Description

Fix serviceAccountName template to properly generate the SA name based on the inputs. Improve CI by running helm template for each ci values file.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • CI update/change

Pre-flight checklist

  • I have performed a self-review of my code
  • The change is covered by tests
  • The documentation is updated accordingly
  • PR label set

@mazay mazay added the bug Something isn't working label Nov 3, 2024
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.57%. Comparing base (fec0a83) to head (3c4a20b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #964   +/-   ##
=======================================
  Coverage   42.57%   42.57%           
=======================================
  Files           9        9           
  Lines         822      822           
=======================================
  Hits          350      350           
  Misses        442      442           
  Partials       30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mazay mazay merged commit 1704c8d into master Nov 3, 2024
25 checks passed
@mazay mazay deleted the hotfix/sa-name branch November 3, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant