Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension #65

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Add extension #65

merged 3 commits into from
Mar 12, 2024

Conversation

maypok86
Copy link
Owner

@maypok86 maypok86 commented Mar 7, 2024

Description

Added Extension feature.

Related issue(s)

✅ Checklist for your Pull Request

Related changes (conditional)

  • Tests

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from
      silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
  • Public contracts

    • My changes doesn't break project license.

Stylistic guide (mandatory)

  • My code complies with the styles guide.

  • My commit history is clean (only contains changes relating to my
    issue/pull request and no reverted-my-earlier-commit changes) and commit
    messages start with identifiers of related issues in square brackets.

    Example: [#42] Short commit description

    If necessary both of these can be achieved even after the commits have been
    made/pushed using rebase and squash.

Before merging (mandatory)

  • Check target branch of PR is set correctly

@maypok86 maypok86 changed the title Add advanced Add extension Mar 12, 2024
@maypok86 maypok86 force-pushed the maypok86/#56-get-expiration branch from deb8495 to f7746d8 Compare March 12, 2024 18:13
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 93.87755% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 95.87%. Comparing base (18da5c2) to head (f7746d8).

Files Patch % Lines
internal/core/cache.go 86.84% 3 Missing and 2 partials ⚠️
internal/s3fifo/small.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   95.43%   95.87%   +0.44%     
==========================================
  Files          24       26       +2     
  Lines        1314     1382      +68     
==========================================
+ Hits         1254     1325      +71     
+ Misses         37       35       -2     
+ Partials       23       22       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maypok86 maypok86 merged commit 4fac815 into main Mar 12, 2024
16 checks passed
@maypok86 maypok86 deleted the maypok86/#56-get-expiration branch July 28, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request Get Expiration With Get
2 participants