Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more rich stats #61

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Add more rich stats #61

merged 3 commits into from
Mar 4, 2024

Conversation

maypok86
Copy link
Owner

@maypok86 maypok86 commented Mar 3, 2024

Description

Added collection of additional statistics, such as:

  • Number of rejected sets
  • Number of evicted entries
  • Sum of costs of evicted entries

Related issue(s)

✅ Checklist for your Pull Request

Related changes (conditional)

  • Tests

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from
      silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
  • Public contracts

    • My changes doesn't break project license.

Stylistic guide (mandatory)

  • My code complies with the styles guide.

  • My commit history is clean (only contains changes relating to my
    issue/pull request and no reverted-my-earlier-commit changes) and commit
    messages start with identifiers of related issues in square brackets.

    Example: [#42] Short commit description

    If necessary both of these can be achieved even after the commits have been
    made/pushed using rebase and squash.

Before merging (mandatory)

  • Check target branch of PR is set correctly

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 95.63%. Comparing base (c66ac1f) to head (9e82d9a).

Files Patch % Lines
stats.go 93.54% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   95.62%   95.63%           
=======================================
  Files          22       23    +1     
  Lines        1235     1282   +47     
=======================================
+ Hits         1181     1226   +45     
- Misses         36       37    +1     
- Partials       18       19    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maypok86 maypok86 force-pushed the maypok86/#57-rich-stats branch from 32a969f to 9e82d9a Compare March 3, 2024 20:24
@maypok86 maypok86 force-pushed the maypok86/#57-rich-stats branch from 9e82d9a to afdfd26 Compare March 4, 2024 09:38
@maypok86 maypok86 merged commit 6b88ca0 into main Mar 4, 2024
5 checks passed
@maypok86 maypok86 deleted the maypok86/#57-rich-stats branch March 4, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Adding more rich stats
2 participants