Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node generation and proactive expiration policies #58

Merged
merged 2 commits into from
Mar 2, 2024

Conversation

maypok86
Copy link
Owner

@maypok86 maypok86 commented Mar 1, 2024

Description

Added node generation and proactive expiration policies:

  • Disabled
  • Fixed (queue)
  • Variable (timer wheel)

Related issue(s)

✅ Checklist for your Pull Request

Related changes (conditional)

  • Tests

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from
      silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
  • Public contracts

    • My changes doesn't break project license.

Stylistic guide (mandatory)

  • My code complies with the styles guide.

  • My commit history is clean (only contains changes relating to my
    issue/pull request and no reverted-my-earlier-commit changes) and commit
    messages start with identifiers of related issues in square brackets.

    Example: [#42] Short commit description

    If necessary both of these can be achieved even after the commits have been
    made/pushed using rebase and squash.

Before merging (mandatory)

  • Check target branch of PR is set correctly

@maypok86 maypok86 force-pushed the maypok86/#55-node-generation branch from 8fc4145 to d25b87e Compare March 1, 2024 20:40
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.82540% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 95.37%. Comparing base (b0df6d5) to head (d25b87e).

Files Patch % Lines
internal/core/cache.go 95.91% 2 Missing ⚠️
internal/expire/disabled.go 71.42% 2 Missing ⚠️
internal/expire/queue.go 95.00% 1 Missing and 1 partial ⚠️
internal/expire/variable.go 97.64% 1 Missing and 1 partial ⚠️
internal/s3fifo/queue.go 95.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   95.64%   95.37%   -0.28%     
==========================================
  Files          20       22       +2     
  Lines        1194     1232      +38     
==========================================
+ Hits         1142     1175      +33     
- Misses         35       39       +4     
- Partials       17       18       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maypok86 maypok86 merged commit 758caa3 into main Mar 2, 2024
5 checks passed
@maypok86 maypok86 deleted the maypok86/#55-node-generation branch March 3, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node generation
2 participants