Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent deletion listener behavior #101

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

maypok86
Copy link
Owner

@maypok86 maypok86 commented Jul 28, 2024

Description

Fixed inconsistent deletion listener behavior

Related issue(s)

#98

✅ Checklist for your Pull Request

Related changes (conditional)

  • Tests

    • If I added new functionality, I added tests covering it.
    • If I fixed a bug, I added a regression test to prevent the bug from
      silently reappearing again.
  • Documentation

    • I checked whether I should update the docs and did so if necessary:
  • Public contracts

    • My changes doesn't break project license.

Stylistic guide (mandatory)

  • My code complies with the styles guide.

  • My commit history is clean (only contains changes relating to my
    issue/pull request and no reverted-my-earlier-commit changes) and commit
    messages start with identifiers of related issues in square brackets.

    Example: [#42] Short commit description

    If necessary both of these can be achieved even after the commits have been
    made/pushed using rebase and squash.

Before merging (mandatory)

  • Check target branch of PR is set correctly

Sorry, something went wrong.

@maypok86 maypok86 changed the title [#98] Fixed inconsistent listener behavior Fixed inconsistent listener behavior Jul 28, 2024
@maypok86 maypok86 force-pushed the maypok86/#98-inconsistent-listener branch from 26699bd to 7f72200 Compare July 29, 2024 19:40
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.81529% with 5 lines in your changes missing coverage. Please review.

Project coverage is 95.86%. Comparing base (e57f61b) to head (7f72200).
Report is 3 commits behind head on main.

Files Patch % Lines
internal/s3fifo/small.go 78.57% 3 Missing ⚠️
internal/expiry/disabled.go 0.00% 1 Missing ⚠️
internal/s3fifo/ghost.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   96.30%   95.86%   -0.45%     
==========================================
  Files          26       26              
  Lines        1382     1377       -5     
==========================================
- Hits         1331     1320      -11     
- Misses         31       35       +4     
- Partials       20       22       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maypok86 maypok86 changed the title Fixed inconsistent listener behavior Fixed inconsistent deletion listener behavior Jul 29, 2024
@maypok86 maypok86 changed the title Fixed inconsistent deletion listener behavior Fix inconsistent deletion listener behavior Jul 29, 2024
@maypok86 maypok86 merged commit 82c3514 into main Jul 29, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants