Fix hashmap node is not deleted

maypok86 · Aug 14, 2024 · 43d7576 · 43d7576
1 parent 3880b58
commit 43d7576
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/internal/core/cache.go b/internal/core/cache.go
@@ -219,8 +219,12 @@ func (c *Cache[K, V]) GetNode(key K) (node.Node[K, V], bool) {
 	}
 
 	if n.HasExpired() {
-		n.Die()
-		c.writeBuffer.Push(newExpiredTask(n))
+		// avoid duplicate push
+		deleted := c.hashmap.DeleteNode(n)
+		if deleted != nil {
+			n.Die()
+			c.writeBuffer.Push(newExpiredTask(n))
+		}
 		c.stats.IncMisses()
 		return nil, false
 	}