Handle unexpected operation ids in schema #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case that the schema of the service has another operation_id than 'zaaktypen_list', the list method gives a value error when trying to retrieve the URL path. With the operation method, we can just use the URL path directly.
SilviaAmAm
force-pushed
the
fix/handle_unexpected_operation_ids
branch
2 times, most recently
from
e0355d9 to
180939e
Compare
SilviaAmAm
force-pushed
the
fix/handle_unexpected_operation_ids
branch
from
180939e to
250e7dc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 72.01% 72.33% +0.32%
==========================================
Files 39 39
Lines 1522 1522
Branches 216 216
==========================================
+ Hits 1096 1101 +5
+ Misses 359 354 -5
Partials 67 67 ☔ View full report in Codecov by Sentry. |
sergei-maertens
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes open-formulieren/open-forms#3743