Fix handling of zaaktypen responses #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viicos
changed the title
sergei-maertens
approved these changes
Dec 11, 2023
| @@ -35,11 +35,11 @@ def get_zaaktypen() -> Dict[Service, List[Dict[str, Any]]]: | |||
| while response["next"]: | |||
| next_url = urlparse(response["next"]) | |||
| query = parse_qs(next_url.query) | |||
| new_page = int(query["page"][0]) + 1 | |||
| new_page = int(query["page"][0]) | |||
There was a problem hiding this comment.
Had to check if our new pagination helper is also affected, but that one doesn't bother with parsing stuff at all so nice one 🎉
I had a suspicion it had something to do with pagination, I just expected it to end up in an infinite loop 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
Second commit fixes open-formulieren/open-forms#3664 in two ways:
client.list, resulting in thepagequery param not being updated, and thus making the same request until we hit OOM.pagequery param of the next URL was wrongly incremented. This issue was hidden by the first one.