Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#13] reuse open-api-workflows workflows #30

Merged
merged 8 commits into from
Oct 17, 2024

Conversation

SonnyBA
Copy link
Contributor

@SonnyBA SonnyBA commented Sep 18, 2024

Fixes maykinmedia/open-api-framework#13

Changes

Reuses open-api-workflows workflows to make CI jobs consistent across the different projects.

@SonnyBA SonnyBA force-pushed the feature/13-consistent-ci-configuration branch from 0808d88 to 1aee9aa Compare September 18, 2024 10:13
@SonnyBA SonnyBA self-assigned this Sep 18, 2024
@SonnyBA SonnyBA marked this pull request as ready for review September 18, 2024 10:24
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.50%. Comparing base (45f34cf) to head (8d5aca7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   92.50%   92.50%           
=======================================
  Files          54       54           
  Lines        1054     1054           
=======================================
  Hits          975      975           
  Misses         79       79           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SonnyBA SonnyBA force-pushed the feature/13-consistent-ci-configuration branch from 6d3af29 to 91c3f1c Compare October 4, 2024 10:04
Copy link
Contributor

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SonnyBA I noticed that Open Klant does run lint-oas (https://github.com/maykinmedia/open-klant/actions/runs/11178494080/job/31076177429?pr=238), but here I don't see it (though it does seem to be configured)

@SonnyBA SonnyBA merged commit 84919d9 into master Oct 17, 2024
15 checks passed
@SonnyBA SonnyBA deleted the feature/13-consistent-ci-configuration branch October 17, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make CI pipelines the same across projects
4 participants