💄 #73 - style: use @maykin-ui/admin-ui for list view styling #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenvandescheur
force-pushed
the
feature/#73-list-view
branch
2 times, most recently
from
a84f805 to
2b86977
Compare
SilviaAmAm
approved these changes
Feb 28, 2024
| @@ -37,7 +43,7 @@ const DashboardView = () => { | |||
| const { loading: loadingZaaktypen, error: errorZaaktypen } = useAsync(async () => { | |||
| if (!selectedCatalogus) return; | |||
|
|
|||
| const zaaktypenEndpoint = `catalogi/zaaktypen/?status=alles${ | |||
| const zaaktypenEndpoint = `catalogi/zaaktypen/?status=alles&page=1${ | |||
There was a problem hiding this comment.
Is this in preparation for this endpoint to support pagination? Should it maybe be added later?
There was a problem hiding this comment.
I think this is a mistake, thanks for noticing!
| backgroundColor: 'white', | ||
| borderBottom: '1px solid', | ||
| borderColor: 'divider', | ||
| <> |
There was a problem hiding this comment.
Is the <>...</> needed? I think everything is inside the List tag?
There was a problem hiding this comment.
I think you're right
svenvandescheur
force-pushed
the
feature/#73-list-view
branch
from
2b86977 to
2cfba11
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
=======================================
Coverage 94.12% 94.12%
=======================================
Files 68 68
Lines 1446 1446
=======================================
Hits 1361 1361
Misses 85 85 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for merge