Feature/46 product nl api #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Floris272
force-pushed
the
feature/46-product-nl-api
branch
from
a29bdbd to
fe12f0a
Compare
|
@Coperh please review this PR today, this so we can prep an intermediate release of OP |
Coperh
requested changes
Jan 10, 2025
There was a problem hiding this comment.
Three things:
- Product admin list crashes if there is any product.
- Default admin index has onderwerp which no longer exists ( Probably renamed to thema)
- The end date can be set to before the start date. I assume you don't want this and I think you should prevent it from happening now instead of in the future
Comment on lines
8
to
9
| start_datum = factory.Faker("date") | ||
| eind_datum = factory.Faker("date") |
There was a problem hiding this comment.
Was looking at here and the end date can be before the start date. The model and admin also allow it
There was a problem hiding this comment.
Made start & end date optional on the model as that would've happened in a future pr anyway and added validation so that they cannot be the same.
There was a problem hiding this comment.
I more meant that this is valid:
start_datum = datetime.date(2024, 1, 2)
eind_datum = datetime.date(2024, 12, 31)
Coperh
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes