Feature/46 locatie nl api #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coperh
approved these changes
Jan 3, 2025
Comment on lines
+48
to
+49
| locaties = LocatieSerializer(many=True, read_only=True) | ||
| locatie_ids = serializers.PrimaryKeyRelatedField( |
There was a problem hiding this comment.
Not entirely sure about this. I wonder how this is done in the other APIs
There was a problem hiding this comment.
Open zaak uses an array of URI's for request and responses. see besluittypen of resultaattypen.
I could add another endpoint later that returns the product_type with just ids or uri's.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds locaties app consisting of the models Locatie, Organisatie & Contact.
Removed method to add coordinates to locations based on address for now, also changed db to postgres instead of postgis because of this.
Location & Organisation use the same abstract base model, because a location should have contact information & an organisation address details. Location & Organisation should be kept separate.
Some other fields will be added to organisation & Location in a later PR.