Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/oi integration fixes #39

Merged
merged 10 commits into from
Nov 8, 2024
Merged

Conversation

Floris272
Copy link
Collaborator

@Floris272 Floris272 commented Oct 29, 2024

fixes some issues with OI and other stuff.

  • Originally added tinymce.HTMLFIELD to all textfields but some fields in OI do not use the CKEditorWidget and are rendered as text so the fields in OP are changed back.
  • Added GeoAdminMixin to show the map in the admin after the address has been set on Location or Organisation.
  • Added OpenFormSlug field to ProductType that can be set from OF when a form is generated.

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.10%. Comparing base (c56b396) to head (aaba0ae).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   84.95%   85.10%   +0.14%     
==========================================
  Files          90       90              
  Lines        1987     2007      +20     
  Branches      169      173       +4     
==========================================
+ Hits         1688     1708      +20     
  Misses        269      269              
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Floris272 Floris272 marked this pull request as ready for review October 29, 2024 12:50
@Floris272 Floris272 requested a review from swrichards October 29, 2024 12:53
Copy link
Contributor

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, een nitpick, een vraag.

@Floris272 Floris272 merged commit a5e235e into main Nov 8, 2024
7 checks passed
@Floris272 Floris272 deleted the feature/oi-integration-fixes branch November 8, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants