Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geodata to location #37

Merged
merged 6 commits into from
Oct 24, 2024
Merged

Add geodata to location #37

merged 6 commits into from
Oct 24, 2024

Conversation

Floris272
Copy link
Collaborator

Adds geodata to location & organisation

@Floris272 Floris272 linked an issue Oct 16, 2024 that may be closed by this pull request
2 tasks
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 79.51807% with 17 lines in your changes missing coverage. Please review.

Project coverage is 84.95%. Comparing base (29da38d) to head (ddd034c).

Files with missing lines Patch % Lines
...c/open_producten/locations/serializers/location.py 45.45% 12 Missing ⚠️
src/open_producten/utils/geocode.py 87.50% 4 Missing ⚠️
src/open_producten/locations/models/location.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   85.22%   84.95%   -0.27%     
==========================================
  Files          89       90       +1     
  Lines        1908     1987      +79     
  Branches      165      169       +4     
==========================================
+ Hits         1626     1688      +62     
- Misses        252      269      +17     
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Floris272 Floris272 marked this pull request as ready for review October 23, 2024 14:44
@Floris272 Floris272 requested a review from swrichards October 23, 2024 14:44
src/open_producten/conf/base.py Outdated Show resolved Hide resolved
src/open_producten/locations/models/location.py Outdated Show resolved Hide resolved
src/open_producten/locations/models/location.py Outdated Show resolved Hide resolved
src/open_producten/locations/models/location.py Outdated Show resolved Hide resolved
@Floris272 Floris272 requested a review from swrichards October 24, 2024 15:20
@Floris272 Floris272 merged commit c56b396 into main Oct 24, 2024
7 checks passed
@Floris272 Floris272 deleted the feature/36-geodata branch November 8, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add geodata to location & organisation
3 participants