update api spec

maykinmedia · Sep 17, 2024 · f0292ee · f0292ee
1 parent 00dd2c8
commit f0292ee
Show file tree

Hide file tree

Showing 2 changed files with 163 additions and 219 deletions.
diff --git a/src/open_producten/products/tests/api/test_product.py b/src/open_producten/products/tests/api/test_product.py
@@ -63,7 +63,7 @@ def test_read_product_without_credentials_returns_error(self):
         response = self.client.get(self.path)
         self.assertEqual(response.status_code, 401)
 
-    def create_product(self):
+    def _create_product(self):
         return ProductFactory.create(bsn="111222333")
 
     def test_create_product(self):
@@ -218,7 +218,7 @@ def test_create_product_with_data_for_field_not_part_of_product_type_returns_err
         self.assertEqual(Field.objects.count(), 1)
 
     def test_update_product(self):
-        product = self.create_product()
+        product = self._create_product()
 
         data = self.data | {"end_date": datetime.date(2025, 12, 31)}
         response = self.put(product.id, data)
@@ -227,7 +227,7 @@ def test_update_product(self):
         self.assertEqual(Product.objects.count(), 1)
 
     def test_update_product_without_bsn_or_kvk(self):
-        product = self.create_product()
+        product = self._create_product()
 
         data = self.data.copy()
         data.pop("bsn")
@@ -250,7 +250,7 @@ def test_update_product_data(self):
         field = FieldFactory.create(
             product_type=self.product_type, type=FieldTypes.TEXTFIELD, is_required=True
         )
-        product = self.create_product()
+        product = self._create_product()
         data_instance = DataFactory.create(product=product, field=field, value="abc")
 
         data = self.data | {"data": [{"id": data_instance.id, "value": "123"}]}
@@ -267,7 +267,7 @@ def test_update_product_with_duplicate_data_ids_returns_error(self):
         field = FieldFactory.create(
             product_type=self.product_type, type=FieldTypes.TEXTFIELD, is_required=True
         )
-        product = self.create_product()
+        product = self._create_product()
         data_instance = DataFactory.create(product=product, field=field, value="abc")
 
         data = self.data | {
@@ -298,9 +298,9 @@ def test_update_product_with_data_not_part_of_product_returns_error(
         field = FieldFactory.create(
             product_type=self.product_type, type=FieldTypes.TEXTFIELD, is_required=True
         )
-        product = self.create_product()
+        product = self._create_product()
         data_instance = DataFactory.create(
-            product=self.create_product(), field=field, value="abc"
+            product=self._create_product(), field=field, value="abc"
         )
 
         data = self.data | {
@@ -329,7 +329,7 @@ def test_update_product_with_no_existing_data_object_returns_error(
         FieldFactory.create(
             product_type=self.product_type, type=FieldTypes.TEXTFIELD, is_required=True
         )
-        product = self.create_product()
+        product = self._create_product()
 
         dummy_id = uuid.uuid4()
 
@@ -357,7 +357,7 @@ def test_update_product_with_invalid_data_returns_error(self):
         field = FieldFactory.create(
             product_type=self.product_type, type=FieldTypes.NUMBER, is_required=True
         )
-        product = self.create_product()
+        product = self._create_product()
         data_instance = DataFactory.create(product=product, field=field, value="123")
 
         data = self.data | {
@@ -381,7 +381,7 @@ def test_update_product_with_invalid_data_returns_error(self):
         )
 
     def test_partial_update_product(self):
-        product = self.create_product()
+        product = self._create_product()
 
         data = {"end_date": datetime.date(2025, 12, 31)}
         response = self.patch(product.id, data)
@@ -393,7 +393,7 @@ def test_partial_update_product_data(self):
         field = FieldFactory.create(
             product_type=self.product_type, type=FieldTypes.TEXTFIELD, is_required=True
         )
-        product = self.create_product()
+        product = self._create_product()
         data_instance = DataFactory.create(product=product, field=field, value="abc")
 
         data = {"data": [{"id": data_instance.id, "value": "123"}]}
@@ -407,23 +407,23 @@ def test_partial_update_product_data(self):
         self.assertEqual(data_instance.value, "123")
 
     def test_read_products(self):
-        product = self.create_product()
+        product = self._create_product()
 
         response = self.get()
 
         self.assertEqual(response.status_code, 200)
         self.assertEqual(response.data, [product_to_dict(product)])
 
     def test_read_product(self):
-        product = self.create_product()
+        product = self._create_product()
 
         response = self.get(product.id)
 
         self.assertEqual(response.status_code, 200)
         self.assertEqual(response.data, product_to_dict(product))
 
     def test_read_product_with_data(self):
-        product = self.create_product()
+        product = self._create_product()
         field = FieldFactory.create(
             product_type=self.product_type, is_required=True, type="textfield"
         )
@@ -433,7 +433,7 @@ def test_read_product_with_data(self):
         self.assertEqual(response.data, product_to_dict(product))
 
     def test_delete_product(self):
-        product = self.create_product()
+        product = self._create_product()
         response = self.delete(product.id)
 
         self.assertEqual(response.status_code, 204)