Merge pull request #23 from maykinmedia/feature/18-authentication

Feature/18 authentication

src/open_producten/conf/base.py

@@ -13,6 +13,7 @@
     # 'django.contrib.sitemaps',
     # External applications.
     # Project applications.
+    "rest_framework.authtoken",
     "localflavor",
     "treebeard",
     "open_producten.accounts",
@@ -56,8 +57,13 @@
 #
 # Django rest framework
 #
-
 REST_FRAMEWORK = {
+    "DEFAULT_AUTHENTICATION_CLASSES": [
+        "rest_framework.authentication.TokenAuthentication",
+    ],
+    "DEFAULT_PERMISSION_CLASSES": [
+        "rest_framework.permissions.IsAuthenticated",
+    ],
     "DEFAULT_SCHEMA_CLASS": "drf_spectacular.openapi.AutoSchema",
     "DEFAULT_PARSER_CLASSES": [
         "rest_framework.parsers.JSONParser",

src/open_producten/products/tests/api/test_product.py

@@ -3,6 +3,7 @@
 
 from freezegun import freeze_time
 from rest_framework.exceptions import ErrorDetail
+from rest_framework.test import APIClient
 
 from open_producten.products.models import Data, Product
 from open_producten.products.tests.factories import DataFactory, ProductFactory
@@ -47,6 +48,7 @@ def product_to_dict(product):
 class TestProduct(BaseApiTestCase):
 
     def setUp(self):
+        super().setUp()
         self.product_type = ProductTypeFactory.create()
         self.data = {
             "product_type_id": self.product_type.id,
@@ -57,7 +59,11 @@ def setUp(self):
         }
         self.path = "/api/v1/products/"
 
-    def create_product(self):
+    def test_read_product_without_credentials_returns_error(self):
+        response = APIClient().get(self.path)
+        self.assertEqual(response.status_code, 401)
+
+    def _create_product(self):
         return ProductFactory.create(bsn="111222333")
 
     def test_create_product(self):
@@ -212,7 +218,7 @@ def test_create_product_with_data_for_field_not_part_of_product_type_returns_err
         self.assertEqual(Field.objects.count(), 1)
 
     def test_update_product(self):
-        product = self.create_product()
+        product = self._create_product()
 
         data = self.data | {"end_date": datetime.date(2025, 12, 31)}
         response = self.put(product.id, data)
@@ -221,7 +227,7 @@ def test_update_product(self):
         self.assertEqual(Product.objects.count(), 1)
 
     def test_update_product_without_bsn_or_kvk(self):
-        product = self.create_product()
+        product = self._create_product()
 
         data = self.data.copy()
         data.pop("bsn")
@@ -244,7 +250,7 @@ def test_update_product_data(self):
         field = FieldFactory.create(
             product_type=self.product_type, type=FieldTypes.TEXTFIELD, is_required=True
         )
-        product = self.create_product()
+        product = self._create_product()
         data_instance = DataFactory.create(product=product, field=field, value="abc")
 
         data = self.data | {"data": [{"id": data_instance.id, "value": "123"}]}
@@ -261,7 +267,7 @@ def test_update_product_with_duplicate_data_ids_returns_error(self):
         field = FieldFactory.create(
             product_type=self.product_type, type=FieldTypes.TEXTFIELD, is_required=True
         )
-        product = self.create_product()
+        product = self._create_product()
         data_instance = DataFactory.create(product=product, field=field, value="abc")
 
         data = self.data | {
@@ -292,9 +298,9 @@ def test_update_product_with_data_not_part_of_product_returns_error(
         field = FieldFactory.create(
             product_type=self.product_type, type=FieldTypes.TEXTFIELD, is_required=True
         )
-        product = self.create_product()
+        product = self._create_product()
         data_instance = DataFactory.create(
-            product=self.create_product(), field=field, value="abc"
+            product=self._create_product(), field=field, value="abc"
         )
 
         data = self.data | {
@@ -323,7 +329,7 @@ def test_update_product_with_no_existing_data_object_returns_error(
         FieldFactory.create(
             product_type=self.product_type, type=FieldTypes.TEXTFIELD, is_required=True
         )
-        product = self.create_product()
+        product = self._create_product()
 
         dummy_id = uuid.uuid4()
 
@@ -351,7 +357,7 @@ def test_update_product_with_invalid_data_returns_error(self):
         field = FieldFactory.create(
             product_type=self.product_type, type=FieldTypes.NUMBER, is_required=True
         )
-        product = self.create_product()
+        product = self._create_product()
         data_instance = DataFactory.create(product=product, field=field, value="123")
 
         data = self.data | {
@@ -375,7 +381,7 @@ def test_update_product_with_invalid_data_returns_error(self):
         )
 
     def test_partial_update_product(self):
-        product = self.create_product()
+        product = self._create_product()
 
         data = {"end_date": datetime.date(2025, 12, 31)}
         response = self.patch(product.id, data)
@@ -387,7 +393,7 @@ def test_partial_update_product_data(self):
         field = FieldFactory.create(
             product_type=self.product_type, type=FieldTypes.TEXTFIELD, is_required=True
         )
-        product = self.create_product()
+        product = self._create_product()
         data_instance = DataFactory.create(product=product, field=field, value="abc")
 
         data = {"data": [{"id": data_instance.id, "value": "123"}]}
@@ -401,23 +407,23 @@ def test_partial_update_product_data(self):
         self.assertEqual(data_instance.value, "123")
 
     def test_read_products(self):
-        product = self.create_product()
+        product = self._create_product()
 
         response = self.get()
 
         self.assertEqual(response.status_code, 200)
         self.assertEqual(response.data, [product_to_dict(product)])
 
     def test_read_product(self):
-        product = self.create_product()
+        product = self._create_product()
 
         response = self.get(product.id)
 
         self.assertEqual(response.status_code, 200)
         self.assertEqual(response.data, product_to_dict(product))
 
     def test_read_product_with_data(self):
-        product = self.create_product()
+        product = self._create_product()
         field = FieldFactory.create(
             product_type=self.product_type, is_required=True, type="textfield"
         )
@@ -427,7 +433,7 @@ def test_read_product_with_data(self):
         self.assertEqual(response.data, product_to_dict(product))
 
     def test_delete_product(self):
-        product = self.create_product()
+        product = self._create_product()
         response = self.delete(product.id)
 
         self.assertEqual(response.status_code, 204)

src/open_producten/producttypes/tests/api/test_category.py

@@ -1,6 +1,7 @@
 from django.forms import model_to_dict
 
 from rest_framework.exceptions import ErrorDetail
+from rest_framework.test import APIClient
 
 from open_producten.producttypes.models import Category, Link
 from open_producten.producttypes.tests.factories import (
@@ -35,12 +36,17 @@ def category_to_dict(category):
 class TestCategoryViewSet(BaseApiTestCase):
 
     def setUp(self):
+        super().setUp()
         self.data = {
             "name": "test-category",
             "parent_category": None,
         }
         self.path = "/api/v1/categories/"
 
+    def test_read_category_without_credentials_returns_error(self):
+        response = APIClient().get(self.path)
+        self.assertEqual(response.status_code, 401)
+
     def test_create_minimal_category(self):
         response = self.post(self.data)
 

src/open_producten/producttypes/tests/api/test_category_question.py

@@ -1,5 +1,7 @@
 from django.forms import model_to_dict
 
+from rest_framework.test import APIClient
+
 from open_producten.producttypes.models import Category, Question
 from open_producten.producttypes.tests.factories import CategoryFactory, QuestionFactory
 from open_producten.utils.tests.cases import BaseApiTestCase
@@ -14,13 +16,18 @@ def question_to_dict(question):
 class TestCategoryQuestion(BaseApiTestCase):
 
     def setUp(self):
+        super().setUp()
         self.category = CategoryFactory.create()
         self.data = {"question": "18?", "answer": "eligible"}
         self.path = f"/api/v1/categories/{self.category.id}/questions/"
 
-    def create_question(self):
+    def _create_question(self):
         return QuestionFactory.create(category=self.category)
 
+    def test_read_question_without_credentials_returns_error(self):
+        response = APIClient().get(self.path)
+        self.assertEqual(response.status_code, 401)
+
     def test_create_question(self):
         response = self.post(self.data)
 
@@ -29,7 +36,7 @@ def test_create_question(self):
         self.assertEqual(self.category.questions.first().question, "18?")
 
     def test_update_question(self):
-        question = self.create_question()
+        question = self._create_question()
 
         data = self.data | {"question": "21?"}
         response = self.put(question.id, data)
@@ -39,7 +46,7 @@ def test_update_question(self):
         self.assertEqual(Category.objects.first().questions.first().question, "21?")
 
     def test_partial_update_question(self):
-        question = self.create_question()
+        question = self._create_question()
 
         data = {"question": "21?"}
         response = self.patch(question.id, data)
@@ -49,23 +56,23 @@ def test_partial_update_question(self):
         self.assertEqual(Category.objects.first().questions.first().question, "21?")
 
     def test_read_questions(self):
-        question = self.create_question()
+        question = self._create_question()
 
         response = self.get()
 
         self.assertEqual(response.status_code, 200)
         self.assertEqual(response.data, [question_to_dict(question)])
 
     def test_read_question(self):
-        question = self.create_question()
+        question = self._create_question()
 
         response = self.get(question.id)
 
         self.assertEqual(response.status_code, 200)
         self.assertEqual(response.data, question_to_dict(question))
 
     def test_delete_question(self):
-        question = self.create_question()
+        question = self._create_question()
         response = self.delete(question.id)
 
         self.assertEqual(response.status_code, 204)

src/open_producten/producttypes/tests/api/test_condition.py

@@ -1,3 +1,5 @@
+from rest_framework.test import APIClient
+
 from open_producten.producttypes.models import Condition
 from open_producten.utils.tests.cases import BaseApiTestCase
 from open_producten.utils.tests.helpers import model_to_dict_with_id
@@ -12,6 +14,7 @@ def condition_to_dict(condition):
 class TestProductTypeCondition(BaseApiTestCase):
 
     def setUp(self):
+        super().setUp()
         self.data = {
             "name": "test condition",
             "question": "?",
@@ -20,8 +23,9 @@ def setUp(self):
         }
         self.path = "/api/v1/conditions/"
 
-    def create_condition(self):
-        return ConditionFactory.create()
+    def test_read_condition_without_credentials_returns_error(self):
+        response = APIClient().get(self.path)
+        self.assertEqual(response.status_code, 401)
 
     def test_create_condition(self):
         response = self.post(self.data)
@@ -31,7 +35,7 @@ def test_create_condition(self):
         self.assertEqual(Condition.objects.first().name, "test condition")
 
     def test_update_condition(self):
-        condition = self.create_condition()
+        condition = ConditionFactory.create()
 
         data = self.data | {"name": "updated"}
         response = self.put(condition.id, data)
@@ -41,7 +45,7 @@ def test_update_condition(self):
         self.assertEqual(Condition.objects.first().name, "updated")
 
     def test_partial_update_condition(self):
-        condition = self.create_condition()
+        condition = ConditionFactory.create()
 
         data = {"name": "updated"}
         response = self.patch(condition.id, data)
@@ -51,23 +55,23 @@ def test_partial_update_condition(self):
         self.assertEqual(Condition.objects.first().name, "updated")
 
     def test_read_conditions(self):
-        condition = self.create_condition()
+        condition = ConditionFactory.create()
 
         response = self.get()
 
         self.assertEqual(response.status_code, 200)
         self.assertEqual(response.data, [condition_to_dict(condition)])
 
     def test_read_condition(self):
-        condition = self.create_condition()
+        condition = ConditionFactory.create()
 
         response = self.get(condition.id)
 
         self.assertEqual(response.status_code, 200)
         self.assertEqual(response.data, condition_to_dict(condition))
 
     def test_delete_condition(self):
-        condition = self.create_condition()
+        condition = ConditionFactory.create()
         response = self.delete(condition.id)
 
         self.assertEqual(response.status_code, 204)