Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚚 [#59] moved the old api to legacy file #89

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

bart-maykin
Copy link
Contributor

fixes #59

Moved old api code to legacy file
merged the models used for the old api together in the admin under the label legacy
changed the old api version to be v0.

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2023

Codecov Report

Merging #89 (610b609) into master (5ca61b0) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   96.23%   96.26%   +0.02%     
==========================================
  Files         102      102              
  Lines        3586     3588       +2     
==========================================
+ Hits         3451     3454       +3     
+ Misses        135      134       -1     
Files Coverage Δ
...lant/components/legacy/contactmomenten/__init__.py 100.00% <100.00%> (ø)
...enklant/components/legacy/contactmomenten/admin.py 100.00% <ø> (ø)
...nt/components/legacy/contactmomenten/api/audits.py 100.00% <ø> (ø)
...lant/components/legacy/contactmomenten/api/auth.py 100.00% <ø> (ø)
...t/components/legacy/contactmomenten/api/filters.py 100.00% <100.00%> (ø)
...t/components/legacy/contactmomenten/api/kanalen.py 100.00% <100.00%> (ø)
...nt/components/legacy/contactmomenten/api/schema.py 100.00% <ø> (ø)
...nt/components/legacy/contactmomenten/api/scopes.py 100.00% <ø> (ø)
...mponents/legacy/contactmomenten/api/serializers.py 98.71% <100.00%> (ø)
...ents/legacy/contactmomenten/api/tests/test_auth.py 100.00% <100.00%> (ø)
... and 50 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@joeribekker joeribekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ziet er goed uit MAAR om backwards compatibility te behouden wil ik de API URL toch niet wijzigen. Dan krijgen we maar /api/v1/klanten/ en /api/v1/klantinteracties/ naast elkaar...

Codewise is het in orde, dus enkel de URL patterns.

@bart-maykin bart-maykin force-pushed the feature/59-legacy-api branch 3 times, most recently from 7944a13 to 140e026 Compare October 19, 2023 15:36
@bart-maykin bart-maykin force-pushed the feature/59-legacy-api branch from 140e026 to 7ee6e39 Compare October 20, 2023 08:57
@bart-maykin bart-maykin force-pushed the feature/59-legacy-api branch from 7ee6e39 to d77f426 Compare October 20, 2023 09:37
@joeribekker joeribekker merged commit d368660 into master Oct 20, 2023
11 checks passed
@joeribekker joeribekker deleted the feature/59-legacy-api branch October 20, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Als projectmanager wil ik de oude Klanten en Contactmomenten API archiveren
3 participants