Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#13] reuse open-api-workflows workflows #238

Merged
merged 12 commits into from
Oct 31, 2024
Merged

[#13] reuse open-api-workflows workflows #238

merged 12 commits into from
Oct 31, 2024

Conversation

SonnyBA
Copy link
Contributor

@SonnyBA SonnyBA commented Sep 6, 2024

Fixes maykinmedia/open-api-framework#13

Changes

Reuses open-api-workflows workflows to make CI jobs consistent across the different projects.

@SonnyBA SonnyBA force-pushed the feature/13-consistent-ci-configuration branch from 9f6a3d0 to 86c494a Compare September 16, 2024 10:21
@SonnyBA SonnyBA mentioned this pull request Sep 17, 2024
Closed
@SonnyBA
Copy link
Contributor Author

SonnyBA commented Sep 17, 2024

This PR requires an updated version of OAF, see the code qualities job and the PR made in OAF.

@SonnyBA SonnyBA mentioned this pull request Sep 17, 2024
Closed
2 tasks
@SonnyBA SonnyBA marked this pull request as ready for review September 17, 2024 12:56
@SonnyBA SonnyBA force-pushed the feature/13-consistent-ci-configuration branch from 2f41a28 to 915a644 Compare October 4, 2024 10:12
stevenbal
stevenbal reviewed Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SonnyBA could you solve the merge conflicts? Also one of the jobs is failing, not sure why https://github.com/maykinmedia/open-klant/actions/runs/11178494784/job/31076178777?pr=238

@SonnyBA SonnyBA force-pushed the feature/13-consistent-ci-configuration branch from 12c5370 to 6a4a5f7 Compare October 17, 2024 10:12
@SonnyBA
Copy link
Contributor Author

SonnyBA commented Oct 17, 2024

@stevenbal regarding the failing job, there still is this comment to consider before merging

@bart-maykin bart-maykin self-requested a review October 24, 2024 08:52
@stevenbal stevenbal self-assigned this Oct 25, 2024
@stevenbal stevenbal force-pushed the feature/13-consistent-ci-configuration branch from 6a4a5f7 to a20f0e3 Compare October 25, 2024 09:05
@stevenbal stevenbal marked this pull request as draft October 25, 2024 09:07
@stevenbal stevenbal force-pushed the feature/13-consistent-ci-configuration branch from be3ae06 to 3c2c8be Compare October 25, 2024 09:32
@stevenbal stevenbal mentioned this pull request Oct 25, 2024
Merged
@stevenbal stevenbal force-pushed the feature/13-consistent-ci-configuration branch from 3c2c8be to e80ba3d Compare October 25, 2024 09:54
@stevenbal
⬆️ Upgrade commonground-api-common to 1.13.4
c42cf93 
this version moves the auth middleware to the proper directory, to avoid unnecessary migrations if the authorizations app is unused

also remove the vng_api_common.authorizations.AuthMiddleware from the MIDDLEWARE setting, because Open Klant does not use JWT authentication
@stevenbal stevenbal force-pushed the feature/13-consistent-ci-configuration branch from e80ba3d to c42cf93 Compare October 25, 2024 10:09
@stevenbal stevenbal marked this pull request as ready for review October 25, 2024 10:28
@stevenbal
Copy link
Collaborator

@annashamray @Coperh @bart-maykin this PR is ready for review again

annashamray
annashamray requested changes Oct 25, 2024
View reviewed changes
.github/workflows/codeql.yml Outdated Show resolved Hide resolved
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@stevenbal stevenbal requested a review from annashamray October 31, 2024 09:34
@stevenbal stevenbal force-pushed the feature/13-consistent-ci-configuration branch from c1faaf1 to 95789cc Compare October 31, 2024 14:40
@stevenbal stevenbal merged commit 125bd2c into master Oct 31, 2024
17 checks passed
@stevenbal stevenbal deleted the feature/13-consistent-ci-configuration branch October 31, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenbal stevenbal stevenbal left review comments

@annashamray annashamray annashamray approved these changes

@Coperh Coperh Awaiting requested review from Coperh

@bart-maykin bart-maykin Awaiting requested review from bart-maykin

Assignees

@stevenbal stevenbal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make CI pipelines the same across projects
4 participants
@SonnyBA @stevenbal @annashamray @bart-maykin