-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/100 basic crud #101
Conversation
e3e1219
to
a69ebca
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #101 +/- ##
==========================================
+ Coverage 95.84% 97.24% +1.39%
==========================================
Files 121 151 +30
Lines 3998 7044 +3046
==========================================
+ Hits 3832 6850 +3018
- Misses 166 194 +28 ☔ View full report in Codecov by Sentry. |
4770f5a
to
d71a48b
Compare
d71a48b
to
bd758d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tussendoor review:
Algemeen
- Voor alle identificators (mixin wellicht) de query params toevoegen: objectidentifcatorObjecttype, objectidentifcatorSoortObjectId, objectidentificatorObjectId
- Haal van alle inline resources de extra attributen maar even weg, zodat enkel URL en UUID overblijft.
- Hernoem (in de API serializer) Contactpersoon.organisatie naar Contactpersoon.werkteVoorOrganisatie, en bij alle relaties graag :) Hier kan je ze goed zien: https://vng-realisatie.github.io/klantinteracties/informatiemodel/assets/SIM_Klantinteracties_v006.png
Betrokkene
- digitaalAdres moet een array zijn 0 of meer digitaleAdressen. Model foutje? Vermoed dat we de relatie moeten omdraaien.
- Inline toevoegen van Partij
- Query params toevoegen: klantcontact__nummer, klantcontact__uuid, klantcontact (url), verstrektedigitaalAdres__uuid, verstrekteDigitaalAdres__adres, verstrekteDigitaalAdres (url), wasPartij__nummer, wasPartij__identificator+(attributen bij algemeen), partij (url)
Partij
- Bij Organisatie graag toevoegen: contactpersonen (array van url/uuid partij-objecten)
Interne Taak
- Query params toevoegen: nummer, status, toegewezenActor (url), toegewezenActor__naam, toegewezenActor__identificator+(attributen bij algemeen), navKlantcontact (url), navKlantcontact__uuid, navKlantcontact__nummer
Klantcontact
- Dit is een van de hoofd-resources, dus ik wil hier veel relaties in zoals ook in de admin. Graag de relaties toevoegen naar: gingOverOnderwerpobjecten, omvatteBijlagen, hadBetrokkenen, leideTotInterneTaken
- Query params toevoegen: nummer, kanaal, hadBetrokkene, inhoud__icontains (case insensitive search), onderwerp__icontains
74174a5
to
45fe461
Compare
f9644b0
to
447879d
Compare
447879d
to
66186f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good but many minor changes and a few larger ones:
Actoren
- Add list-query param: naam__icontains
Betrokkene
- Rename URL-path to "betrokkenen" (plural)
- Rename attribute "partij" to "wasPartij"
- Make "wasPartij" a simple inline, just URL and UUID
- Rename "klantcontact" to "hadKlantcontact"
Bijlage
- Rename URL-path to "bijlagen" (plural)
- Resources lack doc-string. The API spec says "bijlage_list" instead of "Alle bijlage opvragen"
- Rename attribute "klantcontact" to "wasBijlageVanKlantcontact"
Digitaal adres
- Rename URL-path to "digitaleadressen" (plural, without underscores)
- Rename attribute "betrokkene" to "verstrektDoorBetrokkene"
- Add attribute "verstrektDoorPartij"
Interne taak
- Rename URL-path to "internetaken" (plural, without underscores)
- Rename attribute "actor" to "toegewezenAanActor"
- Rename attribute "klantcontact" to "aanleidinggevendKlantcontact"
- Make attribute "toelichting" 1000 chars
Klantcontacten
- Rename URL-path to "klantcontacten" (plural)
- Rename attribute "actoren" to "hadBetrokkenActoren"
- Rename attribute "hadBetrokkene" to "hadBetrokkenen" (plural)
- Make "hadBetrokkenen" a simple inline, just URL and UUID
- Rename attribute "leideTotInterneTaken" to "leiddeTotInterneTaken" (typo, double dd)
- Rename attribute "gingOverOnderwerpobject" to "gingOverOnderwerpobjecten" (plural)
Onderwerpobject
- Rename URL-path to "onderwerpobjecten" (plural)
- Resources lack doc-string. The API spec says "onderwerpobject_list" instead of "Alle onderwerpobjecten opvragen"
Partij
- Add list-query params: nummer, indicatieGeheimhouding, indicatieActief, soortPartij, werkteVoorPartij__url, werkteVoorPartij__uuid, werkteVoorPartij__nummer, partijIdentificator__objecttype, partijIdentificator__soortObjectID, partijIdentificator__objectId
- Rename URL-path to "partijen" (plural)
- Attribute "digitaalAdres" should be an array? Is this correct in the model? It should also be renamed to "digitaleAdressen"
- Attribute "betrokkene" should be an array? Is this correct in the model? It should also be renamed to "betrokkenen"
- Add attribute "partijIdentificatoren" as array of objects with uuid and url.
Partij identificatoren
- Rename URL-path to "partij-identificatoren" (plural)
- Rename attribute "partij" to "identificeerdePartij" (plural)
85e6443
to
456624f
Compare
2e14aac
to
635aaa4
Compare
635aaa4
to
f0c0533
Compare
fixes #100
Added simple starting crud api for all model fields