Remove max-requests and add die-on-term uwsgi flag in docker #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…script We've been seeing issues in k8s whereby the uwsgi pod would hang after 10 minutes and persist in a "Terminated" state. The theory is that the max_requests limit is reached, uwsgi tries to restart and k8s interprets this as a failing pod that needs to be replaced, but never is because k8s sends SIGTERM and uwsgi ignores this without the --die-on-term flag. This addresses both issues.
swrichards
force-pushed
the
fix-max-requests-die-on-term-uwsgi
branch
from
b20d753 to
a7ced2c
Compare
alextreme
approved these changes
Dec 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1527 +/- ##
========================================
Coverage 94.25% 94.25%
========================================
Files 1068 1068
Lines 40465 40465
========================================
Hits 38141 38141
Misses 2324 2324 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been seeing issues in k8s whereby the uwsgi pod would hang after 10 minutes and persist in a "Terminated" state. The theory is that the max_requests limit is reached, uwsgi tries to restart and k8s interprets this as a failing pod that needs to be replaced, but never is because k8s sends SIGTERM and uwsgi ignores this without the --die-on-term flag. This addresses both issues.
--die-on-termis needed in analogous environments e.g. Heroku, Upstart.--die-on-term.