Fix assorted issues in the OpenKlant2 service #1525
Conversation
swrichards
force-pushed
the
swr/demo-2024-12-10-fixes
branch
3 times, most recently
from
098abde to
92c8514
Compare
swrichards
force-pushed
the
swr/demo-2024-12-10-fixes
branch
from
92c8514 to
d948da3
Compare
| @@ -1133,7 +1133,7 @@ def create_question( | |||
| if len(question.rstrip()) == 0: | |||
| raise ValueError("You must provide a question") | |||
|
|
|||
| if self.mijn_vragen_actor is None: | |||
| if self.config.mijn_vragen_actor is None: | |||
There was a problem hiding this comment.
We check for and set the mijn_vragen_actor in the __init__ of the service, although we didn't provide for the case when the actor is not set in the config, hence the old cold would give an AttributeError. Alternatively, you could update the class attributes with mijn_vragen_actor: str | uuid.UUID | None = None, then the old check if self.mijn_vragen_actor is None could remain.
There was a problem hiding this comment.
Fair point, but I suggest we keep this for now. I wanted to stay close to parity and the extra check can't hurt, but when we revamp the config we should reconsider these constraints.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1525 +/- ##
===========================================
- Coverage 94.25% 94.25% -0.01%
===========================================
Files 1068 1068
Lines 40465 40466 +1
===========================================
Hits 38141 38141
- Misses 2324 2325 +1 ☔ View full report in Codecov by Sentry. |
No description provided.