[#2931] Update company data on login

[pi-sigma]

Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2931

[swrichards]

Discussed off-line, we'll do this PR first before the selection screen skipper.

[swrichards]

A few issues to do with vestiging/kvk pairs, but maybe we can tackle that later, let's discuss on monday.

[swrichards]

I am not sure these checks have added value: the kvk is the source of truth here I think, we can just overwrite all the fields no (assuming there's a binnenlandsAdres)?

[pi-sigma]

I wouldn't be enough to check for the presence of binnenlandAdres, because each field in binnenlandAdres is potentially null and would have to be checked as well. Some of the fields may actually be required (an address without at least city name would be strange), but I don't know which ones (the spec doesn't say). I find it simpler therefore to get the values from the dict and check if they are different from what's stored on the user.

[swrichards]

Suggested change

	@cache("vestigingsnummer")
	@cache("vestiging:{vestigingsnummer}")

I am a bit concerned by the **kwargs though, I don't think you can currently add that as a parameter in the cache key, but that means you'll always get a cached result even if kwargs changes. Is there any way to actually name the kwargs?

[pi-sigma]

That's not a use case because the only kwarg passed on is the vestigingsnummer. The code is misleading though; kwargs.update suggests that there is other stuff in there. I changed the function signature + body to make clear that we're only passing on the vestigingsnummer.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.27%. Comparing base (235ec5a) to head (c083269).
Report is 4 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1524      +/-   ##
===========================================
+ Coverage    94.25%   94.27%   +0.01%     
===========================================
  Files         1068     1071       +3     
  Lines        40466    40597     +131     
===========================================
+ Hits         38141    38271     +130     
- Misses        2325     2326       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pi-sigma]

At the time of opening this PR we are not able to support separate updates for users with the same kvkNummer but different vesttigingsnummer because our user model treats users with the same kvk as identical. For now, we will only update the company name, treating the hoofdvestiging as the source of truth. Part of the code can be re-used once we decide how to deal with the kvk/vestigingsnummer situation and (potentially) refactor our user model to deal with it.