Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement connectivity-related setup configuration steps with new API #1523

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

@swrichards swrichards force-pushed the swr/refactor-django-setup-configuration-steps branch from 1627555 to 8546b10 Compare December 16, 2024 16:15
@swrichards swrichards changed the base branch from django-setup-configuration-refactor to develop December 16, 2024 16:16
@swrichards swrichards changed the title [#2908] Refactor the OpenZaak config step for the new API Implement connectivity-related setup configuration steps with new API Dec 16, 2024
@swrichards swrichards force-pushed the swr/refactor-django-setup-configuration-steps branch 3 times, most recently from 3a6396a to 5ee66ce Compare December 17, 2024 13:15
@swrichards swrichards marked this pull request as ready for review December 17, 2024 13:15
@swrichards swrichards force-pushed the swr/refactor-django-setup-configuration-steps branch from 5ee66ce to 203f516 Compare December 17, 2024 13:22
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 98.04878% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.13%. Comparing base (1645f79) to head (203f516).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...open_inwoner/configurations/bootstrap/openklant.py 95.00% 2 Missing ⚠️
src/open_inwoner/configurations/bootstrap/zgw.py 94.11% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1523      +/-   ##
===========================================
- Coverage    94.26%   94.13%   -0.14%     
===========================================
  Files         1070     1063       -7     
  Lines        40557    39205    -1352     
===========================================
- Hits         38231    36904    -1327     
+ Misses        2326     2301      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swrichards swrichards requested a review from alextreme December 17, 2024 16:49
@@ -208,6 +208,9 @@ jobs:
name: Check that documentation for configuration steps is up-to-date
runs-on: ubuntu-latest

# Disabled while we complete the upgrade to the latest setup-configuration
if: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hasn't this been done?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No not yet, there's some complexities.

@swrichards swrichards merged commit 0d4c736 into develop Dec 18, 2024
22 checks passed
@swrichards swrichards deleted the swr/refactor-django-setup-configuration-steps branch December 18, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Admin-OIDC configuration via django-setup-configuration
4 participants