Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ [#2279] Upgrade pydantic to 2.6.4 #1118

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Mar 25, 2024

task: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2279

based on #1103, so that should be merged first

@stevenbal stevenbal marked this pull request as draft March 25, 2024 16:18
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@09a9ef7). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1118   +/-   ##
==========================================
  Coverage           ?   95.04%           
==========================================
  Files              ?      923           
  Lines              ?    32340           
  Branches           ?        0           
==========================================
  Hits               ?    30737           
  Misses             ?     1603           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevenbal stevenbal force-pushed the feature/2279-pydantic-v2 branch 3 times, most recently from bb34b05 to 7d6a92b Compare March 26, 2024 09:53
@stevenbal stevenbal changed the base branch from develop to feature/2180-qmatic-reschedule-or-remove-appointment March 26, 2024 09:53
Base automatically changed from feature/2180-qmatic-reschedule-or-remove-appointment to develop March 26, 2024 13:21
@stevenbal stevenbal marked this pull request as ready for review March 26, 2024 13:21
@stevenbal stevenbal force-pushed the feature/2279-pydantic-v2 branch from 7d6a92b to 739a7ac Compare March 26, 2024 13:31
Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The JSONEncoderMixin is quite a bit easier on the eyes now.

Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple.

This annotated-types package also had some interesting stuff.

@stevenbal stevenbal merged commit 4341c59 into develop Mar 28, 2024
17 checks passed
@stevenbal stevenbal deleted the feature/2279-pydantic-v2 branch March 28, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants