✨ [#2192] Display newsletter form errors to user #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
force-pushed
the
feature/2192-newsletter-subscribe-error-handling
branch
from
a06ffbc to
3a44a8c
Compare
Base automatically changed from
feature/2157-nieuwsbrief-mijn-profiel
to
develop
March 15, 2024 11:02
pi-sigma
requested changes
Mar 15, 2024
pi-sigma
approved these changes
Mar 15, 2024
Bartvaderkin
suggested changes
Mar 18, 2024
stevenbal
force-pushed
the
feature/2192-newsletter-subscribe-error-handling
branch
from
86d3e57 to
37ffc9f
Compare
Bartvaderkin
approved these changes
Mar 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1091 +/- ##
===========================================
+ Coverage 95.00% 95.03% +0.02%
===========================================
Files 909 911 +2
Lines 31804 32072 +268
===========================================
+ Hits 30215 30479 +264
- Misses 1589 1593 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task: https://taiga.maykinmedia.nl/project/open-inwoner/task/2192
Based on #1082, so that should be merged first