[#2098] Show case-related questions in case detail view #1059

pi-sigma · 2024-02-27T11:36:58Z

Taiga: #2098

Related: PR #1045

pi-sigma · 2024-03-01T12:38:45Z

@stevenbal @jiromaykin I thought it makes sense to paginate the questions for particular cases, though it is not entirely straightforward (we need to paginate inside a detail view + the query param for the page is not easily accessible because of the inner/outer view split for cases). Let me know if this functionality is not needed, then I'll get rid of it.

I just saw that this was requested as part of a follow-up (Taiga #2148)

src/open_inwoner/templates/pages/cases/status_inner.html

src/open_inwoner/cms/cases/tests/test_contactform.py

src/open_inwoner/cms/cases/tests/test_htmx.py

src/open_inwoner/openklant/tests/factories.py

jiromaykin · 2024-03-04T10:25:22Z

[...] we need to paginate inside a detail view + the query param for the page is not easily accessible because of the inner/outer view split for cases). Let me know if this functionality is not needed, then I'll get rid of it.

So, I think we agree the pagination is not needed for the detailview - the detailview needs a collapse/readmore button.
The other task (2148) about the pagination was just a pure styling task (make pagination centered on all views, so make them look the same through the entire project, but that task is for me).

jiromaykin

I need more 'Vragen' data in order to properly review this.

src/open_inwoner/templates/pages/cases/status_inner.html

src/open_inwoner/templates/pages/cases/status_outer.html

src/open_inwoner/templates/pages/cases/status_inner.html

codecov-commenter · 2024-03-04T17:58:17Z

Codecov Report

Attention: Patch coverage is 94.78261% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 95.01%. Comparing base (3bbd1a3) to head (c8f3f74).
Report is 28 commits behind head on develop.

Files	Patch %	Lines
src/open_inwoner/openklant/clients.py	80.00%	4 Missing ⚠️
src/open_inwoner/accounts/views/contactmoments.py	86.66%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##           develop    #1059    +/-   ##
=========================================
  Coverage    95.00%   95.01%            
=========================================
  Files          896      909    +13     
  Lines        31449    31917   +468     
=========================================
+ Hits         29879    30325   +446     
- Misses        1570     1592    +22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/open_inwoner/scss/components/Contactmomenten/Contactmomenten.scss

src/open_inwoner/cms/cases/tests/test_htmx.py

src/open_inwoner/cms/cases/tests/test_contactform.py

src/open_inwoner/accounts/views/contactmoments.py

src/open_inwoner/cms/cases/views/status.py

src/open_inwoner/openzaak/tests/test_case_detail.py

src/open_inwoner/cms/cases/tests/test_contactform.py

jiromaykin

I am not sure how to fix the tangled javascript, but if we change the 'dropdown' class into an 'expand' class than this may work as an intermediate solution.
Also some small requests to change the Card SCSS and some html classes for the primary buttons.

src/open_inwoner/js/components/card/ToggleHideSelection.js

src/open_inwoner/templates/pages/questions/questions.html

jiromaykin · 2024-03-14T11:29:53Z

src/open_inwoner/templates/pages/questions/questions.html

+        {# redirect to fetch klantcontactmoment from contactmoment #}
+        <a href="{% url 'cases:kcm_redirect' contactmoment.uuid %}" class="card card--compact card--stretch card--toggle-hide contactmomenten__link">
+            <div class="card__body">
+                {% render_list %}


There might not be a need to use a UL or list-items inside this card.
But I am not sure if this is the definite design:
https://www.figma.com/file/iKGhWhstaLIlFSaND2q7cE/OIP---Designs-(new)?type=design&node-id=1839%3A12002&mode=design&t=BLYIn4BeQOFtBCyU-1

src/open_inwoner/templates/pages/cases/status_inner.html

src/open_inwoner/js/components/card/ToggleHideSelection.js

src/open_inwoner/templates/pages/cases/status_inner.html

src/open_inwoner/scss/components/Card/Card.scss

src/open_inwoner/js/components/card/ToggleHideSelection.js

src/open_inwoner/templates/pages/cases/status_inner.html

src/open_inwoner/js/components/card/ToggleHideSelection.js

requirements/dev-local.txt

Bartvaderkin · 2024-03-15T10:48:14Z

src/open_inwoner/openzaak/tests/test_case_detail.py

+            created=dateutil.parser.parse(
+                self.zaak_informatie_object_old["registratiedatum"]


Note for other reviewers: we discussed this and dateutil.parser.parse is acceptable here because the zgw_consumers factory() also uses that and it produces different timezones then datetime.fromisoformat so the equality check failed.

There might be a way to convert it but let's declare that out of scope for this PR because it is a hassle.

Bartvaderkin

👍 Let's go! 🚀

outdated

pi-sigma force-pushed the feature/2098-link-vragen-aanvragen branch 4 times, most recently from bceaad1 to 931d85b Compare February 28, 2024 12:00

pi-sigma mentioned this pull request Feb 28, 2024

[#2099] Re-design mijn vragen #1045

Merged

pi-sigma force-pushed the feature/2098-link-vragen-aanvragen branch 4 times, most recently from 75f91e7 to e780963 Compare March 1, 2024 11:52

pi-sigma marked this pull request as ready for review March 1, 2024 12:31

pi-sigma requested review from stevenbal and jiromaykin March 1, 2024 12:34

stevenbal requested changes Mar 1, 2024

View reviewed changes

jiromaykin requested changes Mar 4, 2024

View reviewed changes

src/open_inwoner/templates/pages/cases/status_inner.html Outdated Show resolved Hide resolved

src/open_inwoner/templates/pages/cases/status_inner.html Outdated Show resolved Hide resolved

pi-sigma force-pushed the feature/2098-link-vragen-aanvragen branch 2 times, most recently from 96c8b93 to 1fb0ac6 Compare March 4, 2024 15:11

jiromaykin self-requested a review March 4, 2024 15:47

jiromaykin requested changes Mar 4, 2024

View reviewed changes

src/open_inwoner/templates/pages/cases/status_outer.html Outdated Show resolved Hide resolved

src/open_inwoner/templates/pages/cases/status_inner.html Show resolved Hide resolved

src/open_inwoner/templates/pages/cases/status_inner.html Show resolved Hide resolved

stevenbal mentioned this pull request Mar 4, 2024

✨ [#2149] Display new answer header for mijn vragen list #1075

Merged

pi-sigma force-pushed the feature/2098-link-vragen-aanvragen branch 2 times, most recently from 4b14943 to e59fb16 Compare March 4, 2024 17:43

pi-sigma force-pushed the feature/2098-link-vragen-aanvragen branch 6 times, most recently from 5835a93 to 769b099 Compare March 6, 2024 17:02

pi-sigma force-pushed the feature/2098-link-vragen-aanvragen branch from 701449a to c1c6ab9 Compare March 12, 2024 08:19

jiromaykin requested changes Mar 12, 2024

View reviewed changes

src/open_inwoner/scss/components/Contactmomenten/Contactmomenten.scss Show resolved Hide resolved

Bartvaderkin suggested changes Mar 12, 2024

View reviewed changes

src/open_inwoner/cms/cases/tests/test_htmx.py Outdated Show resolved Hide resolved

src/open_inwoner/cms/cases/tests/test_contactform.py Outdated Show resolved Hide resolved

src/open_inwoner/accounts/views/contactmoments.py Show resolved Hide resolved

pi-sigma added 3 commits March 13, 2024 09:32

[#2098] Show case-related questions in case detail view

14437de

[#2098] Implement redirect from contactmoment in case detail view

4b049f7

[#2098] Display/hide older questions

1e3d523

pi-sigma force-pushed the feature/2098-link-vragen-aanvragen branch 2 times, most recently from c967536 to bfb2dfc Compare March 14, 2024 09:10

pi-sigma marked this pull request as draft March 14, 2024 09:10

Bartvaderkin suggested changes Mar 14, 2024

View reviewed changes

src/open_inwoner/cms/cases/views/status.py Outdated Show resolved Hide resolved

src/open_inwoner/openzaak/tests/test_case_detail.py Outdated Show resolved Hide resolved

src/open_inwoner/cms/cases/tests/test_contactform.py Outdated Show resolved Hide resolved

pi-sigma force-pushed the feature/2098-link-vragen-aanvragen branch from bfb2dfc to 51e14f2 Compare March 14, 2024 09:46

jiromaykin previously requested changes Mar 14, 2024

View reviewed changes

pi-sigma force-pushed the feature/2098-link-vragen-aanvragen branch from 51e14f2 to c4159e8 Compare March 14, 2024 15:51

jiromaykin reviewed Mar 14, 2024

View reviewed changes

src/open_inwoner/templates/pages/cases/status_inner.html Outdated Show resolved Hide resolved

pi-sigma force-pushed the feature/2098-link-vragen-aanvragen branch from c4159e8 to 1dbbf08 Compare March 14, 2024 21:21

stevenbal reviewed Mar 15, 2024

View reviewed changes

src/open_inwoner/js/components/card/ToggleHideSelection.js Outdated Show resolved Hide resolved

pi-sigma force-pushed the feature/2098-link-vragen-aanvragen branch from 1dbbf08 to 1025af6 Compare March 15, 2024 09:23

Bartvaderkin reviewed Mar 15, 2024

View reviewed changes

requirements/dev-local.txt Outdated Show resolved Hide resolved

pi-sigma force-pushed the feature/2098-link-vragen-aanvragen branch from 1025af6 to fcddaf8 Compare March 15, 2024 10:17

pi-sigma marked this pull request as ready for review March 15, 2024 10:18

stevenbal approved these changes Mar 15, 2024

View reviewed changes

Bartvaderkin reviewed Mar 15, 2024

View reviewed changes

Bartvaderkin approved these changes Mar 15, 2024

View reviewed changes

stevenbal requested a review from jiromaykin March 15, 2024 11:40

[#2098] Process PR feedback

c8f3f74

pi-sigma force-pushed the feature/2098-link-vragen-aanvragen branch from fcddaf8 to c8f3f74 Compare March 15, 2024 11:53

alextreme merged commit 9397863 into develop Mar 15, 2024
15 checks passed

alextreme deleted the feature/2098-link-vragen-aanvragen branch March 15, 2024 13:02

pi-sigma mentioned this pull request Mar 21, 2024

[#2235] Fix toggle-hide for case-related questions #1107

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#2098] Show case-related questions in case detail view #1059

[#2098] Show case-related questions in case detail view #1059

pi-sigma commented Feb 27, 2024 •

edited

Loading

pi-sigma commented Mar 1, 2024 •

edited

Loading

jiromaykin commented Mar 4, 2024

jiromaykin left a comment

codecov-commenter commented Mar 4, 2024 •

edited

Loading

jiromaykin left a comment

jiromaykin Mar 14, 2024

Bartvaderkin Mar 15, 2024

Bartvaderkin left a comment

		created=dateutil.parser.parse(
		self.zaak_informatie_object_old["registratiedatum"]

[#2098] Show case-related questions in case detail view #1059

[#2098] Show case-related questions in case detail view #1059

Conversation

pi-sigma commented Feb 27, 2024 • edited Loading

pi-sigma commented Mar 1, 2024 • edited Loading

jiromaykin commented Mar 4, 2024

jiromaykin left a comment

Choose a reason for hiding this comment

codecov-commenter commented Mar 4, 2024 • edited Loading

Codecov Report

jiromaykin left a comment

Choose a reason for hiding this comment

jiromaykin Mar 14, 2024

Choose a reason for hiding this comment

Bartvaderkin Mar 15, 2024

Choose a reason for hiding this comment

Bartvaderkin left a comment

Choose a reason for hiding this comment

pi-sigma commented Feb 27, 2024 •

edited

Loading

pi-sigma commented Mar 1, 2024 •

edited

Loading

codecov-commenter commented Mar 4, 2024 •

edited

Loading