Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#557] Add download endpoint #576

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

SilviaAmAm
Copy link
Collaborator

Partly fixes #557

@SilviaAmAm SilviaAmAm marked this pull request as draft December 23, 2024 16:10
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 90.16393% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.36%. Comparing base (60b1664) to head (7bb6987).

Files with missing lines Patch % Lines
.../src/openarchiefbeheer/destruction/api/viewsets.py 88.23% 4 Missing ⚠️
backend/src/openarchiefbeheer/destruction/utils.py 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
+ Coverage   84.30%   84.36%   +0.05%     
==========================================
  Files         212      212              
  Lines        5716     5775      +59     
  Branches      576      576              
==========================================
+ Hits         4819     4872      +53     
- Misses        897      903       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SilviaAmAm SilviaAmAm force-pushed the feature/557-add-download-endpoint branch from 5654b02 to 4102aa0 Compare December 24, 2024 11:56
@SilviaAmAm SilviaAmAm force-pushed the feature/557-add-download-endpoint branch from 669745d to 3f982fb Compare December 24, 2024 13:41
@SilviaAmAm SilviaAmAm force-pushed the feature/557-add-download-endpoint branch from 3f982fb to 08e2c45 Compare December 24, 2024 14:09
@SilviaAmAm SilviaAmAm marked this pull request as ready for review December 24, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

De definitieve vernietigde meta moet buiten het systeem geëxporteerd kunnen worden
2 participants