⬆️ - chore: update @maykin-ui/admin-ui (and migrate code acco… #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenvandescheur
force-pushed
the
issues/2024-12-03
branch
from
0973b4d to
c60d54e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #538 +/- ##
==========================================
+ Coverage 80.14% 80.31% +0.16%
==========================================
Files 205 204 -1
Lines 5585 5577 -8
Branches 556 549 -7
==========================================
+ Hits 4476 4479 +3
+ Misses 1109 1098 -11 ☔ View full report in Codecov by Sentry. |
Xaohs
requested changes
Dec 10, 2024
frontend/src/hooks/useFields.ts
Outdated
| String(einddatum).split("/"); | ||
| const [archiefactiedatum__gte = "", archiefactiedatum__lte = ""] = | ||
| String(archiefactiedatum).split("/"); | ||
| const [startdatum__gte = null, startdatum__lte = null] = (startdatum && |
There was a problem hiding this comment.
I don't particularly enjoy these assertions, but I tried fiddling with the types and it's quite difficult to get it working neatly due to the TypedSerializedFormData.. type
frontend/src/hooks/useFilter.ts
Outdated
| setCombinedSearchParams({ | ||
| ...(filterData as AttributeData<string>), | ||
| ...(filterData as object), |
There was a problem hiding this comment.
I'm pretty sure this type assertion isn't necessary as T already extends object
| const onSelectionChange = useCallback( | ||
| (selectedRows: ShortProcedureSetting[]) => { | ||
| const newSelected = new Set( | ||
| (selectedRows as unknown as ShortProcedureSetting[]).map( |
There was a problem hiding this comment.
I think this type assertion is unecessary
svenvandescheur
force-pushed
the
issues/2024-12-03
branch
from
98e59e4 to
601011d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rdingly)
Depends on release and pinning of: maykinmedia/admin-ui#160